Skip to content
Snippets Groups Projects

Unified Backups: Introduce `backup_information.json` metadata

Merged Gabriel Mazetto requested to merge 427337-unified-backups-metadata into master
All threads resolved!

What does this MR do and why?

This introduces a new metadata format for the Unified Backups: backup_information.json.

The change from old file in YAML to new file being in JSON is to allow defining a JSON Schema to validate the file in a later stage.

This also makes the two backups incompatible, which removes the need to implement a different validation mechanism on the old one.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

When a Backup is performed, it should include on the root folder a file: backup_information.json with the following keys:

  • metadata_version
  • backup_id
  • created_at
  • gitlab_version
{
  "metadata_version": 2,
  "backup_id": "1712944480_2024_04_12_16.11.0-pre",
  "created_at": "2024-04-12T17:54:40Z",
  "gitlab_version": "16.11.0-pre"
}

Related to #427337 (closed)

Edited by Gabriel Mazetto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Kozono
  • Michael Kozono
  • added 2 commits

    • a7c303e6 - Ensure error is raised and handled when metadata fails
    • 44444835 - Exit 1 when error happens during backup

    Compare with previous version

  • Gabriel Mazetto requested review from @mkozono

    requested review from @mkozono

  • Michael Kozono approved this merge request

    approved this merge request

  • Michael Kozono resolved all threads

    resolved all threads

  • Michael Kozono enabled an automatic merge when the pipeline for 5e2c277a succeeds

    enabled an automatic merge when the pipeline for 5e2c277a succeeds

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :white_check_mark: test report for 44444835

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Systems     | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Create      | 16     | 0      | 6       | 0     | 22    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 52     | 0      | 8       | 0     | 60    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • mentioned in commit e257f03e

  • added workflowstaging label and removed workflowcanary label

  • mentioned in task #456789 (closed)

  • Please register or sign in to reply
    Loading