Skip to content

Fix the merge icon in the reviewers dropdown being incorrect sometimes

Phil Hughes requested to merge ph/fixReviewersCanMergeIcon into master

What does this MR do and why?

Fix the merge icon in the reviewers dropdown being incorrect sometimes

If you select a user that does not appear in the initial user.json request and they have permission to merge and then you select that user we will incorrectly show the cannot merge icon next to their user in the dropdown. This is caused by getting data-can-merge from the hidden input instead of data-can_merge

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports