Fix the merge icon in the reviewers dropdown being incorrect sometimes
What does this MR do and why?
Fix the merge icon in the reviewers dropdown being incorrect sometimes
If you select a user that does not appear in the initial user.json
request and they
have permission to merge and then you select that user we will incorrectly
show the cannot merge icon next to their user in the dropdown.
This is caused by getting data-can-merge
from the hidden input instead of
data-can_merge
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.11
added bugtransient devopscreate frontend groupcode review typebug labels
assigned to @iamphill
added sectiondev label
3 Warnings 6c5292e4: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/users_select/index.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/users_select/index.js'
Reviewer roulette
Category Reviewer Maintainer frontend @viktomas
(UTC+2, 1 hour ahead of author)
@rchanila
(UTC+10, 9 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits af9e4fed and 6c5292e4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for af9e4fed. So we have used data from: cf6cb480.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost Userrequested review from @kushalpandya
- Resolved by Kushal Pandya
added pipeline:mr-approved label
- Resolved by Kushal Pandya
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 6c5292e4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 90 | 0 | 9 | 0 | 99 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 311 | 0 | 19 | 0 | 330 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 6c5292e4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 500 | 1 | 60 | 8 | 561 | ❌ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 526 | 1 | 62 | 8 | 589 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userenabled an automatic merge when the pipeline for 92481389 succeeds
mentioned in commit 22e1d4a0
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label