Skip to content
Snippets Groups Projects

Fix the merge icon in the reviewers dropdown being incorrect sometimes

Merged Phil Hughes requested to merge ph/fixReviewersCanMergeIcon into master

What does this MR do and why?

Fix the merge icon in the reviewers dropdown being incorrect sometimes

If you select a user that does not appear in the initial user.json request and they have permission to merge and then you select that user we will incorrectly show the cannot merge icon next to their user in the dropdown. This is caused by getting data-can-merge from the hidden input instead of data-can_merge

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya approved this merge request

    approved this merge request

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 6c5292e4

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 90     | 0      | 9       | 0     | 99    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 311    | 0      | 19      | 0     | 330   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 6c5292e4

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 500    | 1      | 60      | 8     | 561   | ❌     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 526    | 1      | 62      | 8     | 589   | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya enabled an automatic merge when the pipeline for 92481389 succeeds

    enabled an automatic merge when the pipeline for 92481389 succeeds

  • Kushal Pandya mentioned in commit 22e1d4a0

    mentioned in commit 22e1d4a0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading