Skip to content

Add jwt query param to createBranch url

Carla Drago requested to merge 391432-add-jwt-to-create-branch into master

This adds a query param to the create branch url in the app_descriptor for the GitLab for Jira app. This will ensure that when creating a branch on Jira from the Development Tool panel, the url will contain the correct hostname, rather than the default gitlab.com url.

There have been issues testing this as a GitLab for Jira app needs a pubilc instance to connect to, which the gdk doesn't allow, and a gitpod instance only stays alive for a short time, and it may not be long enough for the change to the connect descriptor file to be applied (from 3 - 48 hours). But since the changes are so minor, and won't break anything, I'm wondering whether we can merge this anyway.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before

create_branch_in_GitLab

After

There have been issues testing this as a GitLab for Jira app needs a pubilc instance to connect to, which the gdk doesn't allow, and a gitpod instance only stays alive for a short time, and it may not be long enough for the change to the connect descriptor file to be applied (from 3 - 48 hours).

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #391432

Edited by Carla Drago

Merge request reports