Make sure `saml_reload_data` helper is called
What does this MR do and why?
Make sure saml_reload_data
helper is called
Included one of the data-
attributes in the
_saml_reload_modal_spec.rb
so we make sure saml_reload_data
helper
is called.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
Merge request reports
Activity
changed milestone to %16.11
assigned to @eduardosanz
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @tvellishetty
(UTC+5.5, 3.5 hours ahead of author)
@acook.gitlab
(UTC-4, 6 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@eduardosanz - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancetest-gap typemaintenance labels
- Resolved by Eduardo Sanz García
@atevans, would you mind reviewing this MR? Thanks!
requested review from @atevans
added groupauthentication label
added devopsgovern sectionsec labels
- Resolved by Eduardo Sanz García
added pipeline:mr-approved label
- Resolved by Allen Cook
@atevans
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added 518 commits
-
2ff5c7f8...f38348d4 - 517 commits from branch
master
- 53b615f0 - Make sure `saml_reload_data` helper is called
-
2ff5c7f8...f38348d4 - 517 commits from branch