Skip to content
Snippets Groups Projects

Make sure `saml_reload_data` helper is called

Merged Eduardo Sanz García requested to merge eduardosanz/smal-modal-1 into master

What does this MR do and why?

Make sure saml_reload_data helper is called

Included one of the data- attributes in the _saml_reload_modal_spec.rb so we make sure saml_reload_data helper is called.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

Edited by Eduardo Sanz García

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @atevans, would you mind reviewing this MR? Thanks!

  • requested review from @atevans

  • Two comments, but neither are fully blocking. Overall I think this is an improvement to the existing specs, so I will approve. Feel free to re-ping for additional approval if my suggestions get added :smile_cat:

  • Andrew Evans approved this merge request

    approved this merge request

  • added 518 commits

    Compare with previous version

  • Eduardo Sanz García changed title from Two improvements to saml_reload_data helper to {+Make sure +}saml_reload_data{++} helper is called

    changed title from Two improvements to saml_reload_data helper to {+Make sure +}saml_reload_data{++} helper is called

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading