Roadmap refactoring: move fetching epics to root component
What does this MR do and why?
This MR is a part of refactoring roadmaps to use VueApollo effort. Here, we are moving the logic for fetching epics to roadmap_app component
MRs for Roadmaps refactoring
| Title | Link |
|---|---|
| Move non-reactive properties from Vuex to injected | !148520 (merged) |
Move fetching child epics logic to epic_item.vue
|
!148826 (merged) |
| Move fetching milestones logic | !149082 (merged) |
|
|
!149246 (merged) |
| Move filter params to root component property | TBD |
| Move local settings to Apollo cache | TBD |
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
changed milestone to %16.11
assigned to @ntepluhina
added typemaintenance label
2 Warnings ⚠ This merge request is quite big (1231 lines changed), please consider splitting it into multiple merge requests. ⚠ 7eb123d5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer frontend @kpalchyk(UTC+3, 1 hour ahead of author)
@pburdette(UTC-4, 6 hours behind author)
Please check reviewer's status!
-
Reviewer is available!
-
Reviewer is unavailable!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 DangerEdited by Ghost User-
added 2 commits
added 344 commits
-
0b08c0ee...c6c3f05b - 334 commits from branch
master - ebd84566 - Implemented fetching epics
- 0144cb59 - Fixed epics pagination
- 574d7bd5 - Refactored isScopedRoadmap to computed
- 82bf0826 - Fixed eslint errors
- 868b1c85 - Removed fetchEpics from the application
- e62f31ca - Cleaned up Vuex
- 2e7d5fe7 - Fixed roadmap filters spec
- ba75e822 - Fixed actions and mutations specs
- abfd5a0a - Fixed linting errors
- ef6870d9 - Fixed epic item details spec
Toggle commit list-
0b08c0ee...c6c3f05b - 334 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 10d29e71 and fdf188d0
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - -0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 10d29e71. So we have used data from: 15961c6d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost Useradded 2 commits
added 2 commits
