Added approval rules to reviewer drawer component
What does this MR do and why?
Added the approval rules list to the reviewers drawer component.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.11
assigned to @iamphill
- A deleted user
added backend label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/merge_requests/components/reviewers/approval_rules.vue
+ data-testid="optional-rules-toggle"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @aalakkad
(UTC+3, 2 hours ahead of author)
@lorenzvanherwaarden
(UTC+2, 1 hour ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 40dbe9f0 and 53035d38
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 40dbe9f0. So we have used data from: 377eec04.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost Useradded 1 commit
- 1c946d9f - Added approval rules to reviewer drawer component
added 1 commit
- a26c3a53 - Added approval rules to reviewer drawer component
added 1 commit
- 07b39379 - Added approval rules to reviewer drawer component
added 1 commit
- 53035d38 - Added approval rules to reviewer drawer component
requested review from @kushalpandya
added pipeline:mr-approved label
- Resolved by Kushal Pandya
@kushalpandya
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
enabled an automatic merge when the pipeline for 2167f3bc succeeds
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 53035d38expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Create | 90 | 0 | 9 | 0 | 99 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 311 | 0 | 19 | 0 | 330 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 53035d38expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 599 | 1 | 66 | 8 | 666 | ❌ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 44 | 0 | 4 | 0 | 48 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 727 | 1 | 78 | 8 | 806 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermentioned in commit bd413fd5