Chore: remove unnecessary attribute
-
Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA
What does this MR do and why?
- Remove unnecessary attribute which causes console error in the devtool.
Since we are using slots to render actions, the attribute is not needed, also the type of the attribute is not matched with the definition, so I am removing this.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Error
Source code
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
added JiHu contribution label
Hey @JeremyWuuuuu!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @JeremyWuuuuu
@gitlab-bot ready @jmiocene
added workflowready for review label and removed workflowin dev label
requested review from @jmiocene
@jmiocene
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
- Resolved by Illya Klymov
Hi @jmiocene, could you help review this MR? Thank you!
3 Warnings This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Labels missing: please ask a reviewer or maintainer to add frontend to this merge request. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @andr3
(UTC+1)
@xanf
(UTC+3)
~"Verify" Reviewer review is optional for ~"Verify" @bsandlin
(UTC-5)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @xanf
added pipeline:mr-approved label
- Resolved by Illya Klymov
@andr3
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
- Resolved by 🤖 GitLab Bot 🤖
@andr3
, thanks for approving this merge request.This is the first time the merge request has been approved. Please wait for AppSec approval before merging.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
mentioned in issue gitlab-org/quality/triage-reports#17198 (closed)
added typebug label