Skip to content

Housekeeper: Stop revealing RuboCop TODOs during autocorrection

Peter Leitzen requested to merge pl-housekeeper-reveal into master

What does this MR do and why?

This MR discards export REVEAL_RUBOCOP_TODO=1 to hide RuboCop during autocorrect again.

Using export REVEAL_RUBOCOP_TODO=1 causes a lot failures in RubocopFixer keep because rubocop complains about revealed TODOs.

It also moves RuboCop autocorrect call into a helper method so it's easier to reuse.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable export REVEAL_RUBOCOP_TODO=1 locally to reveal RuboCop TODOs
  2. Run bundle exec gems/gitlab-housekeeper/bin/gitlab-housekeeper -b pl-housekeeper-reveal -d
Edited by Peter Leitzen

Merge request reports