Skip to content
Snippets Groups Projects

Add vale rule to enforce ordering of history and details

Merged Marcel Amirault requested to merge docs-rules-tier-offering-version-history into master

What does this MR do?

As reported in the related comment, it's easy to accidentally put the DETAILS: and History items in the wrong order, so we should use Vale to enforce this. This rule found one new example in the docs, which was added recently, which is a good indicator that we need the rule.

Related issues

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Marcel Amirault

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • f9733555 - Apply 3 suggestion(s) to 2 file(s)

    Compare with previous version

  • Suzanne Selhorn approved this merge request

    approved this merge request

  • Suzanne Selhorn resolved all threads

    resolved all threads

  • Suzanne Selhorn enabled an automatic merge when the pipeline for 1bfba83f succeeds

    enabled an automatic merge when the pipeline for 1bfba83f succeeds

  • Thank you so much @marcel.amirault :star: Nice work. I applied a few tiny nitpicky suggestions, tested locally, and merged.

    If/when you have time, can you add these history/details rules to all the doc repos? :pray:

  • cc: @dianalogan FYI--adding one more Vale rule to test version history/DETAILS sections. Some of them were out-of-order so they rendered strangely.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading