Skip to content
Snippets Groups Projects

Adds "Allow runner registration token" setting to top-level group

All threads resolved!

What does this MR do and why?

This change adds a new toggle to the CI/CD settings in top-level groups to allow group owners to allow users to enable registration tokens in top-level groups.

Changelog: added

UX note

Unlike other settings in this page, updating this setting uses a full page refresh (submit). This is done to avoid adding this setting to any API, as this setting is discouraged. It's not an ideal UX experience, but I think it's a good compromise as users would not enable this setting often.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

New setting in Group > Settings > CI/CD Settings
Screenshot_2024-04-09_at_23.46.54

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #411923 (closed)

Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • requested review from @fguibert

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for d9b65b36

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Create      | 77     | 0      | 9       | 0     | 86    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 298    | 0      | 19      | 0     | 317   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for d9b65b36

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 79     | 60     | 30      | 0     | 169   | ❌     |
    | Create      | 152    | 0      | 21      | 2     | 173   | ✅     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 257    | 60     | 53      | 2     | 370   | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Miguel Rincon mentioned in merge request !148942 (merged)

    mentioned in merge request !148942 (merged)

  • removed review request for @lorenzvanherwaarden

  • Miguel Rincon added 2 commits

    added 2 commits

    • 77292f99 - Hide group setting when disabled at admin level
    • 70cd4a91 - Update copy text for runner setting

    Compare with previous version

  • Miguel Rincon requested review from @veethika

    requested review from @veethika

  • added 1 commit

    • 5f7a3fd4 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • mentioned in issue #455119 (closed)

  • Miguel Rincon requested review from @veethika

    requested review from @veethika

  • Veethika Mishra approved this merge request

    approved this merge request

  • Miguel Rincon changed the description

    changed the description

  • added 1 commit

    • d9b65b36 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Florie Guibert approved this merge request

    approved this merge request

  • Florie Guibert resolved all threads

    resolved all threads

  • Florie Guibert enabled an automatic merge when the pipeline for 1227d5cc succeeds

    enabled an automatic merge when the pipeline for 1227d5cc succeeds

  • mentioned in commit 9cb8d5f4

  • Miguel Rincon resolved all threads

    resolved all threads

  • Fiona Neill resolved all threads

    resolved all threads

  • mentioned in issue #455336 (closed)

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #411923 (closed)

  • Miguel Rincon
  • Miguel Rincon resolved all threads

    resolved all threads

  • mentioned in issue #456251 (closed)

  • Fernando Cardenas mentioned in merge request !167417 (merged)

    mentioned in merge request !167417 (merged)

  • Please register or sign in to reply
    Loading