Adds "Allow runner registration token" setting to top-level group
What does this MR do and why?
This change adds a new toggle to the CI/CD settings in top-level groups to allow group owners to allow users to enable registration tokens in top-level groups.
Changelog: added
UX note
Unlike other settings in this page, updating this setting uses a full page refresh (submit). This is done to avoid adding this setting to any API, as this setting is discouraged. It's not an ideal UX experience, but I think it's a good compromise as users would not enable this setting often.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
New setting in Group > Settings > CI/CD Settings |
---|
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #411923 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @mrincon
- A deleted user
added backend development guidelines docsimprovement maintenancerefactor typemaintenance labels and removed typefeature label
2 Warnings cc500a80: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This MR contains docs in the /doc/development directory, but any Maintainer (other than the author) can merge. You do not need tech writer review. Reviewer roulette
Category Reviewer Maintainer backend @atevans
(UTC-7, 9 hours behind author)
@ayufan
(UTC+2, same timezone as author)
frontend @cwoolley-gitlab
(UTC-6, 8 hours behind author)
@fguibert
(UTC+10, 8 hours ahead of author)
UX No reviewer available Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved featureaddition label
added 1 commit
- 5c0dbd37 - Adds "Allow runner registration token" setting to top-level group
added 1 commit
- cc500a80 - Adds "Allow runner registration token" setting to top-level group
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 29e383ae and d9b65b36
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.26 MB 4.26 MB - 0.0 % mainChunk 3.23 MB 3.23 MB - 0.0 %
Note: We do not have exact data for 29e383ae. So we have used data from: 0fd50721.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAs discussed on Slack, we should add documentation in the https://docs.gitlab.com/ee/ci/runners/runners_scope.html#create-a-group-runner-with-a-registration-token-deprecated section.
- Resolved by Fiona Neill
@gdoyle can you help me review this MR? Thanks!
requested review from @gdoyle
removed workflowin dev label
mentioned in issue #454316 (closed)
- Resolved by Florie Guibert
@lorenzvanherwaarden can you have a look at this change? Thanks!
requested review from @lorenzvanherwaarden
- Resolved by Florie Guibert
- Resolved by Lorenz van Herwaarden
added pipeline:mr-approved label
- Resolved by Florie Guibert
@lorenzvanherwaarden
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
requested review from @fguibert
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d9b65b36expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d9b65b36expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 79 | 60 | 30 | 0 | 169 | ❌ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 257 | 60 | 53 | 2 | 370 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !148942 (merged)
removed review request for @lorenzvanherwaarden
mentioned in issue #455063 (closed)
requested review from @veethika
- Resolved by Miguel Rincon
mentioned in issue #455119 (closed)
requested review from @veethika
enabled an automatic merge when the pipeline for 1227d5cc succeeds
mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1575 (closed)
- Resolved by Miguel Rincon
@fguibert, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 9cb8d5f4
mentioned in issue #455336 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #411923 (closed)
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in merge request gitlab-org/gitlab-services/design.gitlab.com!3799 (closed)
added releasedcandidate label
- Resolved by Miguel Rincon
mentioned in issue #456251 (closed)
added featureaddition label
removed maintenancerefactor label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label
mentioned in merge request !167417 (merged)