Improve UX multi assignees in MR
(CE Port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31545)
What does this MR do?
Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/11058
Move the warning icon from the side to the avatar.
Testing Case
- Go to a Merge Request
- Add some assignees that can merge and can not merge
Open View
-
It should look like this:
Tooltip text
-
If assignee can merge, $Name -
If assignee can't merge, $Name (cannot merge)
Collapsed View
-
It should look like this:
Tooltip text
-
If all assignees cannot merge: No one can merge -
If the current assignee cannot merge: Cannot merge -
If some assignees cannot merge: 2/5 can merge
Dropdown (search) View
-
It should look like this:
Tooltip text
-
If assignee can't merge, Cannot merge
Warning Icon
-
Should only appear on the assignees that can't merge
Assignees
-
The assignees should be ordered with those that can merge first
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable