Fixed work item layout width
What does this MR do and why?
Currently, we're setting work item layout width with limit-container-width
class, that limits the width to 1006px. However, on the issue page we're only limiting the width of the "content" container, and sidebar is not included in the calculation. On the work item page, we limit both content and sidebar to 1006px which results in much narrower content width.
This MR increases the limit to 1006px + 320px (sidebar width) to achieve the issue-like UI.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- In rails console enable the work items beta feature flag
Feature.enable(:work_items_beta)
- Open any work item in full-window view (not modal)
- Inspect the page and make sure container width is set to 1326px
Related issue: #453997 (closed)
Merge request reports
Activity
changed milestone to %16.11
added UX bugux devopsplan frontend groupproject management sectiondev labels
assigned to @ntepluhina
added typebug label
added Category:Team Planning label
- Resolved by Natalia Tepluhina
@nickleonard could you please take a look at the changes and confirm we want the same resulting container width as on the issue page?
requested review from @nickleonard
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @mkhalifa3
(UTC+2, same timezone as author)
@alexpooley
(UTC+8, 6 hours ahead of author)
frontend @kpalchyk
(UTC+3, 1 hour ahead of author)
@justin_ho
(UTC+7, 5 hours ahead of author)
UX @nickleonard
(UTC-5, 7 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #453997 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5ceccd84 and 8dc85ccc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.25 MB 4.25 MB - 0.0 % mainChunk 3.23 MB 3.23 MB - 0.0 %
Note: We do not have exact data for 5ceccd84. So we have used data from: 62ec11bc.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- A deleted user
added backend label
requested review from @nickleonard
added pipeline:mr-approved label
- Resolved by Florie Guibert
@nickleonard
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 8dc85cccexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Florie Guibert
@fguibert would you mind doing a direct maintainer review here?
requested review from @fguibert
enabled an automatic merge when the pipeline for 564feab8 succeeds
mentioned in commit ca72c9d7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added workflowpost-deploy-db-staging label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label