Skip to content
Snippets Groups Projects

[16.10] Backport Delete callback should use namespace_id

Merged Terri Chu requested to merge cherry-pick-66935ac5 into 16-10-stable-ee
All threads resolved!

What does this MR do and why?

Backport !147459 (merged) to %16.10

From the original MR:

Search::Zoekt::Index delete_from_index callback should use namespace_id (not null) since zoekt_enabled_namespace_id foreign key has ON DELETE SET NULL

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Terri Chu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Terri Chu changed milestone to %16.10

    changed milestone to %16.10

  • assigned to @terrichu

  • Terri Chu changed title from Merge branch 'tchu-fix-indexer-removal-on-enabled-namespace-deleted' into 'master' to [16.10] Backport Delete callback should use namespace_id

    changed title from Merge branch 'tchu-fix-indexer-removal-on-enabled-namespace-deleted' into 'master' to [16.10] Backport Delete callback should use namespace_id

  • Terri Chu marked the checklist item Set the milestone of the merge request to match the target backport branch version. as completed

    marked the checklist item Set the milestone of the merge request to match the target backport branch version. as completed

  • Author Maintainer

    @dgruzd would you mind reviewing this backport MR?

  • Terri Chu requested review from @dgruzd

    requested review from @dgruzd

  • Dmitry Gruzd approved this merge request

    approved this merge request

    • Resolved by Terri Chu

      :wave: @dgruzd, thanks for approving this merge request.

      This is the first time the merge request has been approved. Please ensure the e2e:package-and-test-ee job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the #test-platform Slack channel.

  • Dmitry Gruzd marked the checklist item This MR has been approved by a maintainer (only one approval is required). as completed

    marked the checklist item This MR has been approved by a maintainer (only one approval is required). as completed

  • A deleted user added backend label

    added backend label

  • 1 Warning
    :warning: The e2e:package-and-test-ee job needs to succeed or have approval from a Software Engineer in Test.
    Read the "QA e2e:package-and-test-ee" section for more details.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @akotte profile link current availability (UTC+5.5, 9.5 hours ahead of author) @pskorupa profile link current availability (UTC+1, 5 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    QA e2e:package-and-test-ee

    @terrichu, the package-and-test job must complete before merging this merge request.*

    If there are failures on the package-and-test pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #test-platform Slack channel.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for c1b97640

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Data Stores    | 117    | 0      | 28      | 0     | 145   | ✅     |
    | Govern         | 269    | 0      | 19      | 0     | 288   | ✅     |
    | Plan           | 245    | 0      | 19      | 0     | 264   | ✅     |
    | Package        | 205    | 0      | 37      | 0     | 242   | ✅     |
    | Manage         | 39     | 0      | 11      | 0     | 50    | ✅     |
    | Verify         | 146    | 1      | 30      | 2     | 177   | ❌     |
    | Systems        | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Analytics      | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Monitor        | 32     | 0      | 13      | 0     | 45    | ✅     |
    | Create         | 558    | 0      | 76      | 4     | 634   | ✅     |
    | Fulfillment    | 8      | 0      | 75      | 0     | 83    | ✅     |
    | Ai-powered     | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Configure      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Release        | 15     | 0      | 3       | 0     | 18    | ✅     |
    | Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
    | Growth         | 0      | 0      | 6       | 0     | 6     | ➖     |
    | ModelOps       | 0      | 0      | 3       | 0     | 3     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 1660   | 1      | 336     | 6     | 1997  | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
  • Dmitry Gruzd marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as completed

    marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as completed

  • Dmitry Gruzd marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as incomplete

    marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as incomplete

  • changed milestone to %16.11

  • removed missed:16.10 label

  • Author Maintainer

    The e2e-package-and-test failure should be fixed with !148083 (merged) being merged

  • Terri Chu added 17 commits

    added 17 commits

    • 1a05990e...53cdfb5e - 16 commits from branch 16-10-stable-ee
    • c1b97640 - Merge branch 'tchu-fix-indexer-removal-on-enabled-namespace-deleted' into 'master'

    Compare with previous version

  • Terri Chu marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as completed

    marked the checklist item Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test. as completed

  • Terri Chu resolved all threads

    resolved all threads

  • Terri Chu mentioned in commit 9dce3c3d

    mentioned in commit 9dce3c3d

  • merged

  • mentioned in merge request release-tools!2979 (merged)

Please register or sign in to reply
Loading