Skip to content
Snippets Groups Projects

Create organization behind feature flag

Merged Bojan Marjanovic requested to merge 441531-create-organization-behind-feature-flag into master
1 unresolved thread

What does this MR do and why?

As per Create organization behind feature flag (#441531 - closed), we're enabling organization creation behind a FF. It adds new FF, and reuse it on the frontend and backend parts.

  • hides the New Organization button on the FE side
  • returns an error message if the FF is disabled for the user

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Hidden button Error message
image image

How to set up and validate locally

  1. Checkout the branch
  2. Visit the organizations page http://gdk.test:3000/-/organizations/
  3. Verify that New Organization button is hidden
  4. Enable the FF Feature.enable(:allow_organization_creation, current_user)
  5. Verify that button is displayed correctly
  6. Verify that correct message is displayed when FF is disabled!
  7. Verify that creation works with the FF enabled! :tada:

prerequisite: ui_for_organizations FF should be enabled.

Related to #441531 (closed)

Edited by Bojan Marjanovic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pennells
  • added 1 commit

    Compare with previous version

  • requested review from @apennells

  • A deleted user added feature flag label

    added feature flag label

  • Alex Pennells approved this merge request

    approved this merge request

  • Alex Pennells requested review from @rchanila and removed review request for @apennells

    requested review from @rchanila and removed review request for @apennells

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 9b3fb2a9

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 70     | 0      | 2       | 0     | 72    | ✅     |
    | Create      | 146    | 0      | 15      | 0     | 161   | ✅     |
    | Plan        | 98     | 0      | 4       | 0     | 102   | ✅     |
    | Data Stores | 60     | 0      | 0       | 0     | 60    | ✅     |
    | Govern      | 129    | 0      | 0       | 0     | 129   | ✅     |
    | Package     | 48     | 0      | 11      | 0     | 59    | ✅     |
    | Monitor     | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Manage      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 575    | 0      | 34      | 0     | 609   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 9b3fb2a9

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 326    | 1      | 24      | 0     | 351   | ❌     |
    | Data Stores | 136    | 4      | 36      | 0     | 176   | ❌     |
    | Fulfillment | 7      | 1      | 100     | 0     | 108   | ❌     |
    | Verify      | 196    | 0      | 40      | 4     | 236   | ✅     |
    | Package     | 210    | 0      | 46      | 0     | 256   | ✅     |
    | Manage      | 12     | 0      | 8       | 0     | 20    | ✅     |
    | Create      | 683    | 14     | 96      | 10    | 793   | ❌     |
    | Monitor     | 40     | 0      | 16      | 0     | 56    | ✅     |
    | Govern      | 324    | 2      | 24      | 0     | 350   | ❌     |
    | Release     | 20     | 0      | 4       | 0     | 24    | ✅     |
    | Configure   | 0      | 0      | 12      | 0     | 12    | ➖     |
    | Secure      | 8      | 0      | 4       | 0     | 12    | ✅     |
    | Analytics   | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Growth      | 0      | 0      | 8       | 0     | 8     | ➖     |
    | ModelOps    | 0      | 0      | 4       | 0     | 4     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 1970   | 22     | 426     | 14    | 2418  | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Andrew Evans approved this merge request

    approved this merge request

  • requested review from @allison.browne

  • Bojan Marjanovic changed the description

    changed the description

  • Rahul Chanila approved this merge request

    approved this merge request

  • Rahul Chanila removed review request for @rchanila

    removed review request for @rchanila

  • added 1 commit

    • 9b3fb2a9 - Apply FE maintainer suggestions

    Compare with previous version

  • Bojan Marjanovic reset approvals from @rchanila by pushing to the branch

    reset approvals from @rchanila by pushing to the branch

  • Bojan Marjanovic requested review from @georgekoltsov and removed review request for @allison.browne

    requested review from @georgekoltsov and removed review request for @allison.browne

  • George Koltsov
  • George Koltsov approved this merge request

    approved this merge request

  • George Koltsov resolved all threads

    resolved all threads

  • George Koltsov enabled an automatic merge when the pipeline for 888b33da succeeds

    enabled an automatic merge when the pipeline for 888b33da succeeds

  • mentioned in commit 292d30d2

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • mentioned in issue #452518 (closed)

  • added workflowstaging label and removed workflowcanary label

  • Peter Hegman mentioned in merge request !148347 (merged)

    mentioned in merge request !148347 (merged)

  • Peter Hegman mentioned in merge request !149333 (merged)

    mentioned in merge request !149333 (merged)

  • Peter Hegman mentioned in issue #519124

    mentioned in issue #519124

  • Please register or sign in to reply
    Loading