Create organization behind feature flag
What does this MR do and why?
As per Create organization behind feature flag (#441531 - closed), we're enabling organization creation behind a FF. It adds new FF, and reuse it on the frontend and backend parts.
- hides the
New Organization
button on the FE side - returns an error message if the FF is disabled for the user
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Hidden button | Error message |
---|---|
![]() |
![]() |
How to set up and validate locally
- Checkout the branch
- Visit the organizations page
http://gdk.test:3000/-/organizations/
- Verify that
New Organization
button is hidden - Enable the FF
Feature.enable(:allow_organization_creation, current_user)
- Verify that button is displayed correctly
- Verify that correct message is displayed when FF is disabled!
- Verify that creation works with the FF enabled!
prerequisite: ui_for_organizations
FF should be enabled.
Related to #441531 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @bmarjanovic
added workflowin dev label and removed workflowready for development label
- A deleted user
added feature flag label
2 Warnings 13e5854c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @SamWord
(UTC-4, 5 hours behind author)
@rutgerwessels
(UTC+1, same timezone as author)
frontend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@ankit.panchal
(UTC+5.5, 4.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userremoved feature flag label
- Resolved by Peter Hegman
Hey @atevans
could you please give the initial backend review?And @apennells could you please give the initial frontend review?
requested review from @atevans and @apennells
added workflowin review label and removed workflowin dev label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 35b33f87 and 9b3fb2a9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.25 MB 4.25 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 35b33f87. So we have used data from: 7aae2c6e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User- Resolved by Bojan Marjanovic
- Resolved by Bojan Marjanovic
requested review from @apennells
- A deleted user
added feature flag label