Create organization behind feature flag
What does this MR do and why?
As per Create organization behind feature flag (#441531 - closed), we're enabling organization creation behind a FF. It adds new FF, and reuse it on the frontend and backend parts.
- hides the
New Organization
button on the FE side - returns an error message if the FF is disabled for the user
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Hidden button | Error message |
---|---|
![]() |
![]() |
How to set up and validate locally
- Checkout the branch
- Visit the organizations page
http://gdk.test:3000/-/organizations/
- Verify that
New Organization
button is hidden - Enable the FF
Feature.enable(:allow_organization_creation, current_user)
- Verify that button is displayed correctly
- Verify that correct message is displayed when FF is disabled!
- Verify that creation works with the FF enabled!
prerequisite: ui_for_organizations
FF should be enabled.
Related to #441531 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @bmarjanovic
added workflowin dev label and removed workflowready for development label
- A deleted user
added feature flag label
2 Warnings 13e5854c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @SamWord
(UTC-4, 5 hours behind author)
@rutgerwessels
(UTC+1, same timezone as author)
frontend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@ankit.panchal
(UTC+5.5, 4.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved feature flag label
- Resolved by Peter Hegman
Hey @atevans
could you please give the initial backend review?And @apennells could you please give the initial frontend review?
requested review from @atevans and @apennells
added workflowin review label and removed workflowin dev label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 35b33f87 and 9b3fb2a9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.25 MB 4.25 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 35b33f87. So we have used data from: 7aae2c6e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Bojan Marjanovic
- Resolved by Bojan Marjanovic
requested review from @apennells
- A deleted user
added feature flag label
requested review from @rchanila and removed review request for @apennells
added pipeline:mr-approved label
- Resolved by Bojan Marjanovic
@apennells
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9b3fb2a9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 70 | 0 | 2 | 0 | 72 | ✅ | | Create | 146 | 0 | 15 | 0 | 161 | ✅ | | Plan | 98 | 0 | 4 | 0 | 102 | ✅ | | Data Stores | 60 | 0 | 0 | 0 | 60 | ✅ | | Govern | 129 | 0 | 0 | 0 | 129 | ✅ | | Package | 48 | 0 | 11 | 0 | 59 | ✅ | | Monitor | 10 | 0 | 0 | 0 | 10 | ✅ | | Manage | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 10 | 0 | 0 | 0 | 10 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 575 | 0 | 34 | 0 | 609 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9b3fb2a9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 326 | 1 | 24 | 0 | 351 | ❌ | | Data Stores | 136 | 4 | 36 | 0 | 176 | ❌ | | Fulfillment | 7 | 1 | 100 | 0 | 108 | ❌ | | Verify | 196 | 0 | 40 | 4 | 236 | ✅ | | Package | 210 | 0 | 46 | 0 | 256 | ✅ | | Manage | 12 | 0 | 8 | 0 | 20 | ✅ | | Create | 683 | 14 | 96 | 10 | 793 | ❌ | | Monitor | 40 | 0 | 16 | 0 | 56 | ✅ | | Govern | 324 | 2 | 24 | 0 | 350 | ❌ | | Release | 20 | 0 | 4 | 0 | 24 | ✅ | | Configure | 0 | 0 | 12 | 0 | 12 | ➖ | | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Analytics | 8 | 0 | 0 | 0 | 8 | ✅ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 1970 | 22 | 426 | 14 | 2418 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @allison.browne
- Resolved by Bojan Marjanovic
- Resolved by Bojan Marjanovic
removed review request for @rchanila
reset approvals from @rchanila by pushing to the branch
mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1483 (closed)
- Resolved by George Koltsov
Hey @georgekoltsov
Could you please take over the maintainer's review, since it looks like Allison is OOO.
requested review from @georgekoltsov and removed review request for @allison.browne
- Resolved by George Koltsov
enabled an automatic merge when the pipeline for 888b33da succeeds
mentioned in commit 292d30d2
mentioned in issue #452518 (closed)
added workflowstaging-canary label and removed workflowin review label
@bmarjanovic This merge request was deployed to the workflowstaging-canary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set allow_organization_creation true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowcanary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set allow_organization_creation true --production
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowstaging environment. You may want to enable the associated feature flag on this environment with/chatops run feature set allow_organization_creation true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowproduction environment. You may want to enable the associated feature flag on this environment with/chatops run feature set allow_organization_creation true --production
.This message was generated automatically. You're welcome to improve it.
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !148347 (merged)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !149333 (merged)
added releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#17930 (closed)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label
mentioned in issue gitlab-org/quality/triage-reports#18463 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18942 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19396 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20626 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20971 (closed)
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
mentioned in issue gitlab-org/quality/triage-reports#21555 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22046
mentioned in issue #519124