Skip to content

Finish migrating remove_email quick actions to internal events

Sarah Yasonik requested to merge 439982-sy-finish-email-quick-actions into master

What does this MR do and why?

Usage data for the /remove_email quick action is generated using these internal events:

  • i_quickactions_remove_email_single
  • i_quickactions_remove_email_multiple

However, they were incompletely migrated to use Internal Events. This MR ensures that they are tracked using the correct method.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Set up snowplow micro & run the event monitor (I use colima to run docker for this)
  2. In rails console, run Feature.enable(:issue_email_participants)
  3. Use /invite_email & /remove_email quick actions in an existing issue to trigger the relevant internal events

Testing the removal quick action

Screenshot_2024-03-22_at_11.27.28_AM Screenshot_2024-03-22_at_11.29.28_AM

Verifying results in monitor

Updated at 2024-03-22 15:29:44 UTC [PAUSED]
Monitored events: i_quickactions_remove_email_single, i_quickactions_remove_email_multiple

+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|                                                                          RELEVANT METRICS                                                                           |
+----------------------------------------------------------------------+--------------------------------------+-----------------------+---------------+---------------+
| Key Path                                                             | Monitored Events                     | Instrumentation Class | Initial Value | Current Value |
+----------------------------------------------------------------------+--------------------------------------+-----------------------+---------------+---------------+
| count_distinct_user_id_from_i_quickactions_remove_email_multiple_28d | i_quickactions_remove_email_multiple | RedisHLLMetric        | 0             | 1             |
| count_distinct_user_id_from_i_quickactions_remove_email_single_28d   | i_quickactions_remove_email_single   | RedisHLLMetric        | 0             | 1             |
+----------------------------------------------------------------------+--------------------------------------+-----------------------+---------------+---------------+
+--------------------------------------------------------------------------------------------------------------------------------------+
|                                                           SNOWPLOW EVENTS                                                            |
+--------------------------------------+--------------------------+-----------------------+---------+--------------+------------+------+
| Event Name                           | Collector Timestamp      | Category              | user_id | namespace_id | project_id | plan |
+--------------------------------------+--------------------------+-----------------------+---------+--------------+------------+------+
| i_quickactions_remove_email_multiple | 2024-03-22T15:29:31.573Z | InternalEventTracking | 1       |              |            |      |
| i_quickactions_remove_email_single   | 2024-03-22T15:27:32.143Z | InternalEventTracking | 1       |              |            |      |
+--------------------------------------+--------------------------+-----------------------+---------+--------------+------------+------+

Related to #439982 (closed)

Edited by Sarah Yasonik

Merge request reports