Skip to content

Complete started migrations to internal_events

Problem

While working on #415139 (closed), we have discovered that there are some events that have not been fully migrated to InternalEvents. Those events are listed here, paired with specs that triggered them as something other than Internal Events:

        k8s_api_proxy_requests_unique_users_via_ci_access: ./spec/requests/api/internal/kubernetes_spec.rb
        k8s_api_proxy_requests_unique_users_via_pat_access: ./spec/requests/api/internal/kubernetes_spec.rb
        k8s_api_proxy_requests_unique_users_via_user_access: ./spec/requests/api/internal/kubernetes_spec.rb
        i_analytics_dev_ops_score: ./spec/controllers/admin/dev_ops_report_controller_spec.rb:20
        i_analytics_dev_ops_adoption: ./ee/spec/features/admin/admin_dev_ops_reports_spec.rb:35
        i_quickactions_remove_email_single: ./spec/services/quick_actions/interpret_service_spec.rb
        i_quickactions_remove_email_multiple: ./spec/services/quick_actions/interpret_service_spec.rb
        g_project_management_issue_cross_referenced: ./spec/lib/gitlab/github_import/importer/events/cross_referenced_spec.rb[1:1:1:1:1]

Similarly half-migrated events for the frontend are taken care of in #440704 (closed)

Desired Outcome

We want those events to only be triggered with internal events suite. After achieving that, we can also remove them from the HLLRedisCounter::HALF_MIGRATED_EVENTS const.

Possible Solution

We need to find the places where these events have not been migrated and use the InternalEvents class in those places.

Edited by Sebastian Rehm