Refactor organization groups/projects search to shared component
What does this MR do and why?
Related to #434469 (closed)
The grouptenant scale team is currently working on two initiatives. Building out Organizations MVC and using Vue components built for organizations to refactor group and project lists written in HAML.
This MR moves the filtered search bar used on Organization
-> Groups and projects
to a shared Vue component. In a future MR it will be used for Modernize sorting and filtering in Explore > Gr... (#434469 - closed) and other issues in &9012
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No visual changes, see video to demonstrate everything still works
Screen_Recording_2024-03-21_at_8.49.38_AM
How to set up and validate locally
- Enable the feature flag
echo "Feature.enable(:ui_for_organizations)" | gdk rails c
- Navigate to
/-/organizations/default/groups_and_projects
- Use the search and sort
Merge request reports
Activity
changed milestone to %16.11
assigned to @peterhegman
3 Warnings This merge request is quite big (541 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @rhardarson
(UTC+2, 9 hours ahead of author)
@mgandres
(UTC+8, 15 hours ahead of author)
UX @ameliabauerly
(UTC-7, same timezone as author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Zack Cuddy
@syarynovskyi can you help review the frontend here? If all looks good can you pass off to
@zcuddy
for maintainer review (assuming he has capacity ).
requested review from @syarynovskyi
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
added pipeline:mr-approved label
- Resolved by Zack Cuddy
@syarynovskyi
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
requested review from @zcuddy and removed review request for @syarynovskyi
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e71d537b and dfe4ef02
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.25 MB 4.25 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for e71d537b. So we have used data from: eb1347ac.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for dfe4ef02expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for dfe4ef02expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 249 | 0 | 19 | 0 | 268 | ✅ | | Govern | 271 | 1 | 19 | 0 | 291 | ❌ | | Systems | 10 | 0 | 0 | 0 | 10 | ✅ | | Create | 570 | 0 | 81 | 6 | 651 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 8 | 0 | 75 | 0 | 83 | ✅ | | Package | 205 | 0 | 38 | 0 | 243 | ✅ | | Manage | 38 | 0 | 12 | 0 | 50 | ✅ | | Data Stores | 119 | 0 | 28 | 0 | 147 | ✅ | | Verify | 150 | 0 | 30 | 2 | 180 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1687 | 1 | 343 | 8 | 2031 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
- Resolved by Zack Cuddy
I'll be able to give this a look Monday (2024-03-25) @peterhegman if that works
Edited by Zack Cuddy
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
- Resolved by Peter Hegman
removed review request for @zcuddy
added 1473 commits
-
f9b81609...337c90ef - 1471 commits from branch
master
- f664c3c8 - Refactor organization groups/projects search to shared component
- 9a14d3da - Refactor to use constants
-
f9b81609...337c90ef - 1471 commits from branch
- Resolved by Zack Cuddy
- Resolved by Zack Cuddy
requested review from @zcuddy
- Resolved by Zack Cuddy
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6523214122 spec/features/dashboard/projects_spec.rb#L236
Dashboard Projects avoids an N+1 query in dashboard index 124.62 s < 50.13 s #6523214122 spec/features/dashboard/projects_spec.rb#L39
Dashboard Projects when user has access to the project when role changes displays the right role 62.28 s < 50.13 s #6523214122 spec/features/dashboard/projects_spec.rb#L86
Dashboard Projects when on Your projects tab shows personal projects on personal projects tab 62.46 s < 50.13 s - A deleted user
added rspec:slow test detected label
enabled an automatic merge when the pipeline for 3b02a7f8 succeeds
mentioned in issue #434470 (closed)
mentioned in commit 1dd9d92d
mentioned in issue #25368 (closed)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue #437016 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels