Skip to content
Snippets Groups Projects

Refactor organization groups/projects search to shared component

All threads resolved!

What does this MR do and why?

Related to #434469 (closed)

The grouptenant scale team is currently working on two initiatives. Building out Organizations MVC and using Vue components built for organizations to refactor group and project lists written in HAML.

This MR moves the filtered search bar used on Organization -> Groups and projects to a shared Vue component. In a future MR it will be used for Modernize sorting and filtering in Explore > Gr... (#434469 - closed) and other issues in &9012

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes, see video to demonstrate everything still works

Screen_Recording_2024-03-21_at_8.49.38_AM

How to set up and validate locally

  1. Enable the feature flag
    • echo "Feature.enable(:ui_for_organizations)" | gdk rails c
  2. Navigate to /-/organizations/default/groups_and_projects
  3. Use the search and sort
Edited by Peter Hegman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • approved this merge request

  • requested review from @zcuddy and removed review request for @syarynovskyi

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits e71d537b and dfe4ef02

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.25 MB 4.25 MB - 0.0 %
    mainChunk 3.22 MB 3.22 MB - 0.0 %

    Note: We do not have exact data for e71d537b. So we have used data from: eb1347ac.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for dfe4ef02

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 77     | 0      | 9       | 0     | 86    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 298    | 0      | 19      | 0     | 317   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for dfe4ef02

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Plan           | 249    | 0      | 19      | 0     | 268   | ✅     |
    | Govern         | 271    | 1      | 19      | 0     | 291   | ❌     |
    | Systems        | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Create         | 570    | 0      | 81      | 6     | 651   | ✅     |
    | Analytics      | 7      | 0      | 0       | 0     | 7     | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Fulfillment    | 8      | 0      | 75      | 0     | 83    | ✅     |
    | Package        | 205    | 0      | 38      | 0     | 243   | ✅     |
    | Manage         | 38     | 0      | 12      | 0     | 50    | ✅     |
    | Data Stores    | 119    | 0      | 28      | 0     | 147   | ✅     |
    | Verify         | 150    | 0      | 30      | 2     | 180   | ✅     |
    | Configure      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor        | 36     | 0      | 13      | 0     | 49    | ✅     |
    | Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
    | Release        | 15     | 0      | 3       | 0     | 18    | ✅     |
    | ModelOps       | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Ai-powered     | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Growth         | 0      | 0      | 6       | 0     | 6     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 1687   | 1      | 343     | 8     | 2031  | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy
  • Zack Cuddy removed review request for @zcuddy

    removed review request for @zcuddy

  • Peter Hegman added 1473 commits

    added 1473 commits

    Compare with previous version

  • Peter Hegman
  • Peter Hegman
  • Peter Hegman added 1 commit

    added 1 commit

    Compare with previous version

  • Peter Hegman requested review from @zcuddy

    requested review from @zcuddy

  • Peter Hegman added 1 commit

    added 1 commit

    Compare with previous version

  • Peter Hegman
  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #6523214122 spec/features/dashboard/projects_spec.rb#L236 Dashboard Projects avoids an N+1 query in dashboard index 124.62 s < 50.13 s
    #6523214122 spec/features/dashboard/projects_spec.rb#L39 Dashboard Projects when user has access to the project when role changes displays the right role 62.28 s < 50.13 s
    #6523214122 spec/features/dashboard/projects_spec.rb#L86 Dashboard Projects when on Your projects tab shows personal projects on personal projects tab 62.46 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • Zack Cuddy resolved all threads

    resolved all threads

  • Zack Cuddy approved this merge request

    approved this merge request

  • Zack Cuddy enabled an automatic merge when the pipeline for 3b02a7f8 succeeds

    enabled an automatic merge when the pipeline for 3b02a7f8 succeeds

  • mentioned in issue #434470 (closed)

  • merged

  • Zack Cuddy mentioned in commit 1dd9d92d

    mentioned in commit 1dd9d92d

  • mentioned in issue #25368 (closed)

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #437016 (closed)

  • Please register or sign in to reply
    Loading