Add alphabetical sort for branch names
What does this MR do and why?
Branches returned did not have any default or configurable sorting logic. See #422493 (closed). Hence have added a change to provide alphabetical sorting in this MR.
Since the https://gitlab.com/gitlab-community/gitlab/-/blob/master/app/models/repository.rb?ref_type=heads#L320 returns an array of branch names alphabetical sorting was the most viable option.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
@gitlab-bot ready
@gauravmarwal this merge request currently contains no changes. If you have made changes, the diff may not yet be ready.
We will wait 5 minutes before assigning a reviewer.
If no reviewer is assigned, please use the command:
@gitlab-bot help
.This message was generated automatically. You're welcome to improve it.
Hey @gauravmarwal!
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @gauravmarwal
- Resolved by Terri Chu
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Labels missing: please ask a reviewer or maintainer to add feature flag to this merge request. 1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/repositories/branch_names_finder.rb
Reviewer roulette
Category Reviewer Maintainer backend @pslaughter
(UTC-5)
@schin1
(UTC+8)
database @bwill
(UTC-5)
@a_akgun
(UTC+3)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded linked-issue label
added workflowready for review label and removed workflowin dev label
Hi Coach
@terrichu
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @terrichu
mentioned in issue #422493 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16721 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16734 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16735 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16741 (closed)
changed milestone to %Backlog
added Category:API GraphQL backend devopsmanage featureenhancement groupimport and integrate quick win sectiondev typefeature workflowin review labels and removed workflowready for review label
changed milestone to %16.10
changed milestone to %16.11