Remove default value for requesting_user_id argument
What does this MR do and why?
Related to #442878 (closed)
The argument requesting_user_id
was added to UnassignIssuablesWorker
with a default value in 16.9 in !143511 (merged) following https://docs.gitlab.com/ee/development/sidekiq/compatibility_across_updates.html#multi-step-deployment.
The default value can be removed in 16.11.
Merge request reports
Activity
changed milestone to %16.11
assigned to @euko
added 1 commit
- b6d10def - Remove the default value for requesting_user_id
- A deleted user
added backend label
- Resolved by euko
1 Warning Please follow the Sidekiq development guidelines when changing Sidekiq worker arguments. Reviewer roulette
Category Reviewer Maintainer backend @shreyasagarwal
(UTC+1, 8 hours behind author)
@stanhu
(UTC-7, 16 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
- Resolved by Stan Hu
@thutterer can you review please?
requested review from @thutterer
added 859 commits
-
b6d10def...9a413b45 - 858 commits from branch
master
- bcb89072 - Remove the default value for requesting_user_id
-
b6d10def...9a413b45 - 858 commits from branch
requested review from @stanhu and removed review request for @thutterer
added pipeline:mr-approved label
- Resolved by Stan Hu
@thutterer
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cd29a13eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 68 | 0 | 6 | 0 | 74 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for cd29a13eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 249 | 0 | 19 | 0 | 268 | ✅ | | Create | 153 | 0 | 20 | 0 | 173 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 41 | 0 | 461 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 165 commits
-
bcb89072...1f52aef9 - 164 commits from branch
master
- cd29a13e - Remove the default value for requesting_user_id
-
bcb89072...1f52aef9 - 164 commits from branch
@stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit fa61adcd
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label