Skip to content
Snippets Groups Projects

Remove default value for requesting_user_id argument

All threads resolved!

What does this MR do and why?

Related to #442878 (closed)

The argument requesting_user_id was added to UnassignIssuablesWorker with a default value in 16.9 in !143511 (merged) following https://docs.gitlab.com/ee/development/sidekiq/compatibility_across_updates.html#multi-step-deployment.

The default value can be removed in 16.11.

Edited by euko

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Warning
    :warning: Please follow the Sidekiq development guidelines when changing Sidekiq worker arguments.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @shreyasagarwal profile link current availability (UTC+1, 8 hours behind author) @stanhu profile link current availability (UTC-7, 16 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • euko marked this merge request as ready

    marked this merge request as ready

  • euko changed title from Draft: Remove the default value for requesting_user_id from UnassignIssuablesWorker to Remove default value for requesting_user_id argument

    changed title from Draft: Remove the default value for requesting_user_id from UnassignIssuablesWorker to Remove default value for requesting_user_id argument

  • euko changed the description

    changed the description

  • euko resolved all threads

    resolved all threads

  • euko requested review from @thutterer

    requested review from @thutterer

  • euko added 859 commits

    added 859 commits

    Compare with previous version

  • Thomas Hutterer approved this merge request

    approved this merge request

  • Thomas Hutterer requested review from @stanhu and removed review request for @thutterer

    requested review from @stanhu and removed review request for @thutterer

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for cd29a13e

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 68     | 0      | 6       | 0     | 74    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for cd29a13e

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 249    | 0      | 19      | 0     | 268   | ✅     |
    | Create      | 153    | 0      | 20      | 0     | 173   | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 420    | 0      | 41      | 0     | 461   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • euko added 165 commits

    added 165 commits

    Compare with previous version

  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu resolved all threads

    resolved all threads

  • merged

  • @stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Stan Hu mentioned in commit fa61adcd

    mentioned in commit fa61adcd

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading