Skip to content
Snippets Groups Projects

Adjust purchase flow ux for ramon

Merged Laura Callahan requested to merge 444480-restrict_ramon_seats into master

What does this MR do and why?

Related to #444480

Removes QSR overage alert and adds subheading when Ramon plan is active (maximum seats will only be provided in Ramon plans)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-03-06_at_11.34.20_AM Screenshot_2024-03-06_at_11.35.53_AM

How to set up and validate locally

  • Manually set maximumSeatLimit to a value here
    • ex: return 20;
  • See that the QSR overage alert is not shown and that the subheading is shown
Edited by Laura Callahan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Laura Callahan requested review from @snachnolkar

    requested review from @snachnolkar

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits f29f68f2 and ca066533

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.24 MB 4.24 MB - 0.0 %
    mainChunk 3.22 MB 3.22 MB - 0.0 %

    Note: We do not have exact data for f29f68f2. So we have used data from: 7dbf13be.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Quarantined Fulfillment QA E2E Tests

    The following Fulfillment QA E2E tests are in quarantine. If your changes would be covered by these tests, please be sure to perform manual testing.

    Description Location
    Fulfillment Utilization when admin sets user cap limit for group shows members over limit as pending for approvals ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/saas_user_caps_spec.rb[1:1:1:1]
    Fulfillment Utilization when namespace storage usage hits the limit puts the namespace into read-only mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:1:1]
    Fulfillment Utilization when namespace storage usage goes back down below the limit reverts the namespace back to full-access mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:2:1]
    Fulfillment with existing compute minutes packs behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:3:1:1]
    Fulfillment without active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:1:1:1]
    Fulfillment with an active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:2:1:1]
    Fulfillment Purchase compute minutes with existing compute minutes packs adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:3:1]
    Fulfillment Purchase compute minutes without active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:1:1]
    Fulfillment Purchase compute minutes with an active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:2:1]
  • Sharmad Nachnolkar
  • Laura Callahan added 828 commits

    added 828 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading