Adjust purchase flow ux for ramon
What does this MR do and why?
Related to #444480
Removes QSR overage alert and adds subheading when Ramon plan is active (maximum seats will only be provided in Ramon plans)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Manually set
maximumSeatLimit
to a value here- ex:
return 20;
- ex:
- See that the QSR overage alert is not shown and that the subheading is shown
Merge request reports
Activity
changed milestone to %16.10
assigned to @lcallahan
3 Warnings 3922c388: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. b7693d67: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @dstull
(UTC-4, 2 hours ahead of author)
@arfedoro
(UTC+1, 7 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Paul Gascou-Vaillancourt
- Resolved by Laura Callahan
- Resolved by Artur Fedorov
@snachnolkar Could you do an initial frontend review here?
I think we're good to push this forward despite the CDot side not being in place, as this would be pretty straightforward to adjust if we made any deviations to the planned CDot implementation. WDYT?
requested review from @snachnolkar
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f29f68f2 and ca066533
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.24 MB 4.24 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for f29f68f2. So we have used data from: 7dbf13be.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserQuarantined Fulfillment QA E2E Tests
The following Fulfillment QA E2E tests are in quarantine. If your changes would be covered by these tests, please be sure to perform manual testing.
Description Location Fulfillment Utilization when admin sets user cap limit for group shows members over limit as pending for approvals ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/saas_user_caps_spec.rb[1:1:1:1] Fulfillment Utilization when namespace storage usage hits the limit puts the namespace into read-only mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:1:1] Fulfillment Utilization when namespace storage usage goes back down below the limit reverts the namespace back to full-access mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:2:1] Fulfillment with existing compute minutes packs behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:3:1:1] Fulfillment without active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:1:1:1] Fulfillment with an active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:2:1:1] Fulfillment Purchase compute minutes with existing compute minutes packs adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:3:1] Fulfillment Purchase compute minutes without active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:1:1] Fulfillment Purchase compute minutes with an active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:2:1] - Resolved by Sharmad Nachnolkar
- Resolved by Diana Zubova
- Resolved by Sharmad Nachnolkar
- Resolved by Diana Zubova
- Resolved by Sharmad Nachnolkar
- Resolved by Paul Gascou-Vaillancourt
added 828 commits
-
e23de726...10ddf85d - 826 commits from branch
master
- 6a2b6e73 - Adjust purchase flow ux for ramon
- 8292e51c - Use named slot for label description
-
e23de726...10ddf85d - 826 commits from branch