Skip to content

Make HLLRedisCounter work with :events

Michał Wielich requested to merge michold-fix-redhll-events into master

What does this MR do and why?

Related to #427298 (closed)

With !145007 (merged), we introduced a bug that made it so that newly generated events report as undefined when trying to trigger them with HLLRedisCounter. To fix that, we need to make sure that HLLRedisCounter works with metrics that have just events: key instead of options:.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Add changes from !146063 (merged) with git merge pedropombeiro/440235/add-runner-creation-metrics
  2. Open the rails console
  3. Trigger the new event: Gitlab::InternalEvents.track_event('click_view_runners_button_in_new_runner_form', user: User.find(1), project: Project.first)
  4. Verify that the event has been triggered: for example, enable snowplow micro and check for the new event on http://localhost:9091/micro/good

Merge request reports