Get rid of options key for Metrics based on Internal Events
Problem
Currently, when instrumenting metrics based on internal events, we're adding both an events
and an options
key. This makes the metric yml files harder to parse. Example yml structure:
---
key_path: redis_hll_counters.count_distinct_proj...
description: Monthly count of unique projects where a definition file was created with the CLI
....
time_frame: 28d
data_source: internal_events
data_category: optional
options:
events:
- internal_events_cli_closed
- internal_events_cli_used
events:
- name: internal_events_cli_closed
unique: project.id
- name: internal_events_cli_used
unique: project.id
Desired Outcome
Only the events
key for remains for Metrics with `data_source: internal_events``
Proposed Solution
- Remove the options key from all event definition with
data_source: internal_events
- Modify generator/docs to make sure new metrics only use the
events
key and not theoptions
key.
How to verify
TBD
Edited by Sebastian Rehm