Remove category from Internal Events event definitions - part 1
What does this MR do and why?
In gitlab-org/analytics-section/analytics-instrumentation/metric-dictionary!75 (merged) we added support for event definitions that has internal_events: true
and no category
.
This MR migrates event definitions from the ee
directory.
The non-ee
directory will be migrated in a separate MR.
This MR addresses step 3) in the below plan (copied from the issue)
- Allow event definitions to have an optional
internal_events
property and add it to a single event definition✅ - Make the Metric Dictionary use the
internal_events
property instead ofcategory
ifinternal_events
is present✅ - Make
category
optional in the event definition schema. Migrate first batch of Internal Events event definitions to have nocategory
andinternal_events: true
- Migrate the remaining event definitions
- Modify the generator to output event definitions with
internal_events: true
instead ofcategory: InternalEventTracking
. - Modify the schema to make sure
category: InternalEventTracking
is not allow and migrate any event definition created after step 4 above.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #435201 (closed)
Edited by Jonas Larsen