Remove category from Internal Events event definitions
Problem
With Use body.dataset.page for Internal Events categ... (#435199 - closed) and Use class.name for Internal events category val... (#435200 - closed) we're starting to fill the category
field of an Internal Event automatically. As it's an automatic process it does not make sense to write down the category
in the event definition any more.
Desired outcome
Category is removed from event definition for Internal events. Ideally, we still make sure that Internal Events are somehow distinguishable from "old" events in the YML to also identify those in the Warehouse. The metrics dictionary event display also should still work after this change.
Proposed Solution
- Allow event definitions to have an optional
internal_events
property and add it to a single event definition - Make the Metric Dictionary use the
internal_events
property instead ofcategory
ifinternal_events
is present - Make
category
optional in the event definition schema. Migrate first batch of Internal Events event definitions to have nocategory
andinternal_events: true
- Migrate the remaining event definitions
- Modify the generator to output event definitions with
internal_events: true
instead ofcategory: InternalEventTracking
. - Modify the schema to make sure
category: InternalEventTracking
is not allow and migrate any event definition created after step 4 above.
How to Verify
TBD
Edited by Jonas Larsen