GraphQL: Use query field instead of mutation
What does this MR do and why?
This MR is a follow-up to !145598 (comment 1789427546) to replace the provisionGoogleCloudRunner
mutation with the provisioningSteps
query field. It also renames runnerCloudProvisioningOptions
to runnerCloudProvisioning
, since this is no longer only about options.
EE: true
Closes #438316 (closed)
Review status
Reviews | Reviewer | Status |
---|---|---|
backend (initial) | @10io | ![]() |
backend (maintainer) | @dmeshcharakou | ![]() |
frontend (maintainer) | @mrincon | ![]() |
devopsverify | @vshushlin | ![]() |
authorization | @jarka | ![]() |
groupimport and integrate | @bmarjanovic | ![]() |
documentation | @fneill | ![]() |
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Run the following query in http://gdk.test:3000/-/graphql-explorer:
{ project(fullPath: "gitlab-org/playground") { id runnerCloudProvisioning( provider: GOOGLE_CLOUD cloudProjectId: "dev-gcp-s3c-integrati-9abafed1" ) { ... on CiRunnerGoogleCloudProvisioning { provisioningSteps( region: "us-central1" zone: "us-central1-a" ephemeralMachineType: "n2d-standard-2" runnerToken: "glrt-Ei-AAaaaaAAAaaAA" ) { title languageIdentifier instructions } } } } }
Merge request reports
Activity
changed milestone to %16.10
added devopsverify grouprunner sectionci + 1 deleted label
assigned to @pedropombeiro
mentioned in merge request !145598 (merged)
- A deleted user
7 Warnings This merge request is quite big (612 lines changed), please consider splitting it into multiple merge requests. e616c5d3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. fb7346e5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 395d3b37: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. d4f83932: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. d4f83932: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 70cd5a04: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @rcobb
(UTC-8, 9 hours behind author)
@patrickbajao
(UTC+8, 7 hours ahead of author)
frontend @andr3
(UTC+0, 1 hour behind author)
@himkp
(UTC+1, same timezone as author)
groupimport and integrate (backend) @carlad-gl
(UTC+8, 7 hours ahead of author)
Maintainer review is optional for groupimport and integrate (backend) Verify Reviewer review is optional for Verify @stanhu
(UTC-8, 9 hours behind author)
~"Authorization" Reviewer review is optional for ~"Authorization" @alexbuijs
(UTC+1, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- A deleted user
added Data WarehouseImpact Check label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@pedropombeiro - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by Pedro Pombeiro
added 74 commits
-
aa7bffda...3db2be1d - 71 commits from branch
pedropombeiro/438316/add-script
- 56d3e9be - GraphQL: Use query field instead of mutation
- 1aae930f - Use scalar types
- 7c23a542 - GraphQL: Remove Mutation.provisionGoogleCloudRunner
Toggle commit list-
aa7bffda...3db2be1d - 71 commits from branch
removed Architecture Evolution Blueprint Data WarehouseImpact Check database databasereview pending feature flag frontend + 1 deleted label
- Resolved by Pedro Pombeiro
Hey @10io
, mind doing the backend initial review? This is probably easier to review commit-by-commit.Edited by Pedro Pombeiro
requested review from @10io
- Resolved by Pedro Pombeiro
mentioned in epic &12111 (closed)
added 1 commit
- 0993c3ba - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
added 1 commit
- 0b67231f - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-package-and-test:
test report for e616c5d3expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 149 | 4 | 19 | 4 | 172 | ❌ | | Verify | 147 | 0 | 30 | 3 | 177 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 322 | 4 | 51 | 7 | 377 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for e616c5d3expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 56 | 0 | 5 | 0 | 61 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- ec3d83af - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
added 1 commit
- cc96799a - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
- A deleted user
added frontend label
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
removed review request for @10io
added 241 commits
-
cc96799a...d76a1c11 - 235 commits from branch
master
- 89b6621e - GraphQL: Use query field instead of mutation
- e78854aa - Use scalar types
- d5ff6d5d - GraphQL: Remove Mutation.provisionGoogleCloudRunner
- 6ef79f71 - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
- 17b4abe3 - Minor improvements
- de29b47c - Add missing default_value for runner_token
Toggle commit list-
cc96799a...d76a1c11 - 235 commits from branch
requested review from @10io
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5115da23 and e616c5d3
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.21 MB 4.21 MB - -0.0 % mainChunk 3.21 MB 3.21 MB - -0.0 %
Note: We do not have exact data for 5115da23. So we have used data from: 512e1564.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 138 commits
-
de29b47c...110f977a - 132 commits from branch
master
- 3199d44c - GraphQL: Use query field instead of mutation
- 45263c52 - Use scalar types
- 3a337c6f - GraphQL: Remove Mutation.provisionGoogleCloudRunner
- ac97645f - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
- d6da7f19 - Minor improvements
- 4016786a - Add missing default_value for runner_token
Toggle commit list-
de29b47c...110f977a - 132 commits from branch
Hey @vshushlin
, mind doing the maintainer Verify review?requested review from @vshushlin
requested review from @mrincon
- Resolved by Vladimir Shushlin
Hey @jarka
, mind doing the authorization maintainer review?
requested review from @jarka
- Resolved by Bojan Marjanovic
Hey @bmarjanovic
, mind doing the groupimport and integrate review?
requested review from @bmarjanovic
- Resolved by Pedro Pombeiro
requested review from @fneill
added 2 commits
added pipeline:mr-approved label
- Resolved by Pedro Pombeiro
@vshushlin
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
removed pipeline:mr-approved label
- Resolved by Vladimir Shushlin
Thanks, @pedropombeiro! I did only surface-level review, but it looks good
Great refactoring, and thanks for not postponing itI left one question just out of curiosity =)
removed review request for @vshushlin
added pipeline:mr-approved label
reset approvals from @vshushlin by pushing to the branch
removed review request for @10io
requested review from @dmeshcharakou
removed review request for @fneill
Hi
@fneill
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
reset approvals from @mrincon, @vshushlin, and @10io by pushing to the branch
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
removed review request for @dmeshcharakou
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Bojan Marjanovic
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
removed review request for @mrincon
requested review from @bmarjanovic
removed review request for @bmarjanovic
reset approvals from @bmarjanovic and @dmeshcharakou by pushing to the branch
@vshushlin do you mind reapproving, as the approval was lost with the recent changes?
added 78 commits
-
4fa35910...f379c859 - 68 commits from branch
master
- b71d5c48 - GraphQL: Use query field instead of mutation
- 70cd5a04 - Use scalar types
- 04dfc257 - GraphQL: Remove Mutation.provisionGoogleCloudRunner
- f939d293 - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
- d4f83932 - Minor improvements
- 991d0910 - Add missing default_value for runner_token
- 395d3b37 - Fix spec
- fb7346e5 - Add alias
- b94c5656 - Fix coverage issue
- 77f695c4 - Address MR review comments
Toggle commit list-
4fa35910...f379c859 - 68 commits from branch
reset approvals from @fneill by pushing to the branch
reset approvals from @vshushlin by pushing to the branch
removed review request for @jarka
requested review from @jarka
enabled an automatic merge when the pipeline for 9090f91f succeeds
mentioned in commit 650f801f
mentioned in merge request !146107 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label