Skip to content
Snippets Groups Projects

GraphQL: Use query field instead of mutation

All threads resolved!

What does this MR do and why?

This MR is a follow-up to !145598 (comment 1789427546) to replace the provisionGoogleCloudRunner mutation with the provisioningSteps query field. It also renames runnerCloudProvisioningOptions to runnerCloudProvisioning, since this is no longer only about options.

EE: true

Closes #438316 (closed)

Review status

Reviews Reviewer Status
backend (initial) @10io :white_check_mark:
backend (maintainer) @dmeshcharakou :white_check_mark:
frontend (maintainer) @mrincon :white_check_mark:
devopsverify @vshushlin :white_check_mark:
authorization @jarka :white_check_mark:
groupimport and integrate @bmarjanovic :white_check_mark:
documentation @fneill :white_check_mark:

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run the following query in http://gdk.test:3000/-/graphql-explorer:

    {
      project(fullPath: "gitlab-org/playground") {
        id
        runnerCloudProvisioning(
          provider: GOOGLE_CLOUD
          cloudProjectId: "dev-gcp-s3c-integrati-9abafed1"
        ) {
          ... on CiRunnerGoogleCloudProvisioning {
            provisioningSteps(
              region: "us-central1"
              zone: "us-central1-a"
              ephemeralMachineType: "n2d-standard-2"
              runnerToken: "glrt-Ei-AAaaaaAAAaaAA"
            ) {
              title
              languageIdentifier
              instructions
            }
          }
        }
      }
    }
Edited by Pedro Pombeiro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pedro Pombeiro added 74 commits

    added 74 commits

    • aa7bffda...3db2be1d - 71 commits from branch pedropombeiro/438316/add-script
    • 56d3e9be - GraphQL: Use query field instead of mutation
    • 1aae930f - Use scalar types
    • 7c23a542 - GraphQL: Remove Mutation.provisionGoogleCloudRunner

    Compare with previous version

  • Pedro Pombeiro marked this merge request as draft

    marked this merge request as draft

  • Pedro Pombeiro changed title from Add temporary index for locating orphaned notes to Draft: GraphQL: Use query field instead of mutation

    changed title from Add temporary index for locating orphaned notes to Draft: GraphQL: Use query field instead of mutation

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro added 3 commits

    added 3 commits

    • 0070f241 - GraphQL: Use query field instead of mutation
    • 44492c9f - Use scalar types
    • 66dbf54f - GraphQL: Remove Mutation.provisionGoogleCloudRunner

    Compare with previous version

  • Pedro Pombeiro marked this merge request as ready

    marked this merge request as ready

  • Pedro Pombeiro requested review from @10io

    requested review from @10io

  • Pedro Pombeiro
  • mentioned in epic &12111 (closed)

  • Pedro Pombeiro added 1 commit

    added 1 commit

    • 0993c3ba - GraphQL: Rename `Project.runnerCloudProvisioningOptions`

    Compare with previous version

  • Pedro Pombeiro added 1 commit

    added 1 commit

    • 0b67231f - GraphQL: Rename `Project.runnerCloudProvisioningOptions`

    Compare with previous version

  • Contributor

    E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for e616c5d3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 149    | 4      | 19      | 4     | 172   | ❌     |
    | Verify      | 147    | 0      | 30      | 3     | 177   | ✅     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 322    | 4      | 51      | 7     | 377   | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for e616c5d3

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 56     | 0      | 5       | 0     | 61    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Pedro Pombeiro added 1 commit

    added 1 commit

    • ec3d83af - GraphQL: Rename `Project.runnerCloudProvisioningOptions`

    Compare with previous version

  • Pedro Pombeiro added 1 commit

    added 1 commit

    • cc96799a - GraphQL: Rename `Project.runnerCloudProvisioningOptions`

    Compare with previous version

  • A deleted user added frontend label

    added frontend label

  • David Fernandez
  • David Fernandez
  • David Fernandez removed review request for @10io

    removed review request for @10io

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro deleted the pedropombeiro/438316/add-script branch. This merge request now targets the master branch

    deleted the pedropombeiro/438316/add-script branch. This merge request now targets the master branch

  • Pedro Pombeiro added 241 commits

    added 241 commits

    • cc96799a...d76a1c11 - 235 commits from branch master
    • 89b6621e - GraphQL: Use query field instead of mutation
    • e78854aa - Use scalar types
    • d5ff6d5d - GraphQL: Remove Mutation.provisionGoogleCloudRunner
    • 6ef79f71 - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
    • 17b4abe3 - Minor improvements
    • de29b47c - Add missing default_value for runner_token

    Compare with previous version

  • Pedro Pombeiro requested review from @10io

    requested review from @10io

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 5115da23 and e616c5d3

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.21 MB 4.21 MB - -0.0 %
    mainChunk 3.21 MB 3.21 MB - -0.0 %

    Note: We do not have exact data for 5115da23. So we have used data from: 512e1564.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Pedro Pombeiro added 138 commits

    added 138 commits

    • de29b47c...110f977a - 132 commits from branch master
    • 3199d44c - GraphQL: Use query field instead of mutation
    • 45263c52 - Use scalar types
    • 3a337c6f - GraphQL: Remove Mutation.provisionGoogleCloudRunner
    • ac97645f - GraphQL: Rename `Project.runnerCloudProvisioningOptions`
    • d6da7f19 - Minor improvements
    • 4016786a - Add missing default_value for runner_token

    Compare with previous version

  • Pedro Pombeiro changed the description

    changed the description

  • Hey @vshushlin :waves:, mind doing the maintainer Verify review?

  • Pedro Pombeiro requested review from @vshushlin

    requested review from @vshushlin

  • Hey @mrincon :waves:, mind doing the frontend maintainer review? I believe it is because of the rename that happend in app/assets/javascripts/graphql_shared/possible_types.json

  • Pedro Pombeiro requested review from @mrincon

    requested review from @mrincon

  • Pedro Pombeiro requested review from @jarka

    requested review from @jarka

  • Pedro Pombeiro requested review from @bmarjanovic

    requested review from @bmarjanovic

  • Pedro Pombeiro
  • Pedro Pombeiro requested review from @fneill

    requested review from @fneill

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro added 2 commits

    added 2 commits

    • 03f02d3a - Minor improvements
    • bdb07e82 - Add missing default_value for runner_token

    Compare with previous version

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Vladimir Shushlin changed the description

    changed the description

  • Thanks, @pedropombeiro! I did only surface-level review, but it looks good :thumbsup: Great refactoring, and thanks for not postponing it :heart_eyes:

    I left one question just out of curiosity =)

  • Vladimir Shushlin removed review request for @vshushlin

    removed review request for @vshushlin

  • Pedro Pombeiro added 2 commits

    added 2 commits

    Compare with previous version

  • Pedro Pombeiro added 1 commit

    added 1 commit

    Compare with previous version

  • Pedro Pombeiro reset approvals from @vshushlin by pushing to the branch

    reset approvals from @vshushlin by pushing to the branch

  • Pedro Pombeiro added 1 commit

    added 1 commit

    Compare with previous version

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • David Fernandez approved this merge request

    approved this merge request

  • David Fernandez removed review request for @10io

    removed review request for @10io

  • Miguel Rincon approved this merge request

    approved this merge request

  • requested review from @dmeshcharakou

  • Pedro Pombeiro changed the description

    changed the description

  • Fiona Neill approved this merge request

    approved this merge request

  • Fiona Neill removed review request for @fneill

    removed review request for @fneill

  • Hi @fneill :wave:,

    GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

    This message was generated automatically. You're welcome to improve it.

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro added 1 commit

    added 1 commit

    Compare with previous version

  • Pedro Pombeiro reset approvals from @mrincon, @vshushlin, and @10io by pushing to the branch

    reset approvals from @mrincon, @vshushlin, and @10io by pushing to the branch

  • Pedro Pombeiro changed the description

    changed the description

  • removed review request for @dmeshcharakou

  • Dzmitry (Dima) Meshcharakou approved this merge request

    approved this merge request

  • Bojan Marjanovic
  • Bojan Marjanovic
  • Pedro Pombeiro removed review request for @mrincon

    removed review request for @mrincon

  • Pedro Pombeiro requested review from @bmarjanovic

    requested review from @bmarjanovic

  • Bojan Marjanovic approved this merge request

    approved this merge request

  • Bojan Marjanovic removed review request for @bmarjanovic

    removed review request for @bmarjanovic

  • Pedro Pombeiro added 1 commit

    added 1 commit

    Compare with previous version

  • Pedro Pombeiro reset approvals from @bmarjanovic and @dmeshcharakou by pushing to the branch

    reset approvals from @bmarjanovic and @dmeshcharakou by pushing to the branch

  • Pedro Pombeiro changed the description

    changed the description

  • @vshushlin do you mind reapproving, as the approval was lost with the recent changes? :bow:

  • Pedro Pombeiro resolved all threads

    resolved all threads

  • Pedro Pombeiro added 78 commits

    added 78 commits

    Compare with previous version

  • Pedro Pombeiro reset approvals from @fneill by pushing to the branch

    reset approvals from @fneill by pushing to the branch

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro added 1 commit

    added 1 commit

    Compare with previous version

  • Pedro Pombeiro reset approvals from @vshushlin by pushing to the branch

    reset approvals from @vshushlin by pushing to the branch

  • Jarka Košanová approved this merge request

    approved this merge request

  • Vladimir Shushlin approved this merge request

    approved this merge request

  • Jarka Košanová removed review request for @jarka

    removed review request for @jarka

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro requested review from @jarka

    requested review from @jarka

  • Vladimir Shushlin resolved all threads

    resolved all threads

  • Vladimir Shushlin enabled an automatic merge when the pipeline for 9090f91f succeeds

    enabled an automatic merge when the pipeline for 9090f91f succeeds

  • mentioned in commit 650f801f

  • Pedro Pombeiro mentioned in merge request !146107 (merged)

    mentioned in merge request !146107 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading