Skip to content

Draft: Add keyboard accessible button to move pinned item up in pinned section

Scott de Jonge requested to merge 426762-navigation-reorder-pinned-via-keyboard into master

What does this MR do and why?

Add keyboard accessible button to move pinned item up in pinned section

  • Add <gl-button class="gl-sr-only-focusable"> element in <nav-item>
  • Add pin-move-up event emission on <nav-item>

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

CleanShot_2024-02-22_at_16.45.16

How to set up and validate locally

  1. View new navigation on page with pinned items e.g. http://gdk.test:3000/flightjs/Flight
  2. Use tab to move focus to a pinned nav item in "📌 Pinned" section
  3. The tab key after "Unpin" button should display a "Move up" button for keyboard-users only mouse users should never see this button
  4. TODO: push button to move pinned item up 1 level

Related to #426762

Merge request reports