Add missing ActiveRecord models for ApprovalRules

changed milestone to %16.10

added backend groupsource code maintenancerefactor labels

changed the description

added Category:Source Code Management devopscreate sectiondev labels

added database databasereview pending labels

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@syarynovskyi` (UTC+2, 1 hour ahead of author)	`@digitalmoksha` (UTC-6, 7 hours behind author)
database	`@mhamda` (UTC+1, same timezone as author)	`@euko` (UTC+9, 8 hours ahead of author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

83d5182a - Add missing ActiveRecord models for ApprovalRules

Compare with previous version

added 1 commit

ae420873 - Add missing ActiveRecord models for ApprovalRules

Compare with previous version

changed the description

Hi @ghinfey! Can you please review an addition of new models for database tables.

requested review from @ghinfey

requested review from @igor.drozdov

removed review request for @ghinfey

approved this merge request

@ghinfey, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for e7594260

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 60     | 0      | 9       | 0     | 69    | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 73     | 0      | 10      | 0     | 83    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for e7594260

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 568    | 0      | 58      | 18    | 626   | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 594    | 0      | 60      | 18    | 654   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added 1 commit

e7594260 - Add missing ActiveRecord models for ApprovalRules

Compare with previous version

approved this merge request

requested review from @jdrpereira and removed review request for @igor.drozdov

mentioned in issue #434974 (closed)

mentioned in issue #442736 (closed)

mentioned in issue #442742 (closed)

approved this merge request

added databasereviewed label and removed databasereview pending label

requested review from @tigerwnz

approved this merge request

added databaseapproved label and removed databasereviewed label

resolved all threads

enabled an automatic merge when the pipeline for 69ee11a8 succeeds

merged

Hello @vyaklushin

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning: