Skip to content

Upgrade redis gem - 3rd attempt

Sylvester Chin requested to merge sc1-redis-gem-upgrade-3rd-try into master

What does this MR do and why?

This reverts commit a7f569b2. The fix for the persistent client connections to Redis Sentinel is merged separately in !144960 (merged). The effects of the fix on redis-sidekiq can be seen in gitlab-com/gl-infra/scalability#2867 (comment 1780180832).

See issue gitlab-com/gl-infra/scalability#2867 (closed) for more details on the cause of the previous revert.

This MR purely reverts the commit, effectively identical to gitlab-com/gl-infra/scalability#2867 (closed)

History on attempts:

  1. First try reverted due to NOAUTH bug caused by gitlab's peek instrumentation resolved in gitlab-com/gl-infra/scalability#2826 (closed)
  2. Second try reverted due to persistent sentinel connection bug in redis-client resolved in gitlab-com/gl-infra/scalability#2867 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Sylvester Chin

Merge request reports