Skip to content

Apply redis sentinel connection closing patch to RedisClient

Sylvester Chin requested to merge sc1-redis-client-sentinel-fix into master

What does this MR do and why?

This MR applies the commit of redis-client gem to Gitlab until the fix is released. The fix for sentinel client connection termination will not be released anytime soon since v0.20.0 was cut only a few days ago.

We opt to monkeypatch over directly referencing the branch for robustness.

See gitlab-com/gl-infra/scalability#2867 (comment 1775478649)

This lets us apply the fix against redis-sidekiq specifically since it is mildly affected at the moment (gitlab-com/gl-infra/scalability#2754 (comment 1776420383)).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

The validation steps are described in https://github.com/redis-rb/redis-client/pull/176. We are effectively only adding this commit.

Numbered steps to set up and validate the change are strongly suggested.

Edited by Sylvester Chin

Merge request reports

Loading