Google Chat: Support inline replies
What does this MR do and why?
Support spaces with inline replies by setting the messageReplyOption
query parameter to REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD
, indicating that
messages should be created as replies to the specified threads. The
default value, MESSAGE_REPLY_OPTION_UNSPECIFIED
, always starts a new
thread
This commit also specifies the thread key in the request body instead of
via the deprecated threadKey
query parameter
https://developers.google.com/chat/api/reference/rest/v1/spaces.messages/create#messagereplyoption
https://developers.google.com/chat/api/guides/v1/messages/create#create-message-thread
Fixes #438452 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Create a new Google Chat space
- Add a webhook to the space
- Enable the Google Chat integration in GitLab
- Perform multiple actions that should result in messages that should be created as replies to the same thread, such as opening and closing a merge request
Merge request reports
Activity
Hey @robbie-demuth!
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @robbie-demuth
I've requested access to the community fork, but it hasn't yet been granted. When it has, I'll close this merge request and open a new one from there, if necessary
Edited by robbie-demuthadded linked-issue label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
- Resolved by Bojan Marjanovic
Hi Coach
@pedropombeiro
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @pedropombeiro
- Resolved by robbie-demuth
Looks like there are tests that I didn't know about. Marking as a draft while I update
Edited by robbie-demuth
mentioned in issue gitlab-org/quality/triage-reports#16358 (closed)
added Category:Integrations groupimport and integrate labels
added devopsmanage sectioncore platform labels
mentioned in issue gitlab-org/quality/triage-reports#16359 (closed)
added featureenhancement label
added typefeature label
requested review from @justin_ho and @ashrafkhamis
removed review request for @ashrafkhamis
changed milestone to %16.10
added Technical Writing label
added workflowin review label and removed workflowready for review label
requested review from @.luke
added backend label
added twtriaged label
- Resolved by robbie-demuth
mentioned in issue #438452 (closed)
- Resolved by robbie-demuth
- Resolved by robbie-demuth
- Resolved by robbie-demuth
added workflowin dev label and removed workflowin review label
removed review request for @.luke
added workflowready for review label and removed workflowin dev label
requested review from @.luke
@pedropombeiro
@.luke
@justin_ho
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @ashrafkhamis
added documentation label
added UI text label
added docsfeature label
added workflowin review label and removed workflowready for review label
- Resolved by Luke Duncalfe
@ashrafkhamis
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @pedropombeiro and @ashrafkhamis
requested review from @bmarjanovic and removed review request for @.luke
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/project/integrations/hangouts_chat.md
(Link to current live version) -
doc/user/project/integrations/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @jnutt
(UTC+0)
@grzesiek
(UTC+1)
groupimport and integrate (backend) @rodrigo.tomonari
(UTC-3)
Maintainer review is optional for groupimport and integrate (backend) Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1ae2e612expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 5 | 0 | 26 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1ae2e612expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 153 | 0 | 34 | 0 | 187 | ✅ | | Manage | 39 | 0 | 11 | 2 | 50 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 218 | 0 | 47 | 2 | 265 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by robbie-demuth
- Resolved by robbie-demuth
removed review request for @justin_ho
- Resolved by robbie-demuth
- Resolved by robbie-demuth
- Resolved by robbie-demuth
added workflowready for review label and removed workflowin review label
requested review from @justin_ho
@justin_ho
@bmarjanovic
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
reset approvals from @.luke and @justin_ho by pushing to the branch
- Resolved by Bojan Marjanovic
enabled an automatic merge when all merge checks for 1ae2e612 pass
@robbie-demuth, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
@robbie-demuth, congratulations for getting your first MR merged
If this is your first MR against a GitLab project, we'd like to invite and encourage you to self-nominate yourself for
First MR Merged
swag prize here.Thank you again for contributing, what's your next contribution going to be?
This message was generated automatically. You're welcome to improve it.
mentioned in commit 350c6d20
removed review request for @justin_ho
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
(confused because it says milestone is
16.10
but "expired" (97% done); but https://about.gitlab.com/releases/ says it released back in March)The Google Chat: Support inline replies feature went with v16.10.
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label