Skip to content
Snippets Groups Projects

Google Chat: Support inline replies

Merged robbie-demuth requested to merge robbie-demuth/gitlab:google-chat-inline-replies into master
1 unresolved thread

What does this MR do and why?

Support spaces with inline replies by setting the messageReplyOption query parameter to REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD, indicating that messages should be created as replies to the specified threads. The default value, MESSAGE_REPLY_OPTION_UNSPECIFIED, always starts a new thread

This commit also specifies the thread key in the request body instead of via the deprecated threadKey query parameter

https://developers.google.com/chat/api/reference/rest/v1/spaces.messages/create#messagereplyoption

https://developers.google.com/chat/api/guides/v1/messages/create#create-message-thread

Fixes #438452 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a new Google Chat space
  2. Add a webhook to the space
  3. Enable the Google Chat integration in GitLab
  4. Perform multiple actions that should result in messages that should be created as replies to the same thread, such as opening and closing a merge request
Edited by robbie-demuth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #438452 (closed)

  • :white_check_mark: QA'd successfully :tada:

    image

    and viewing the thread:

    image

    Edited by Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • added workflowin dev label and removed workflowin review label

  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • robbie-demuth added 1 commit

    added 1 commit

    • 0dd067ed - Google Chat: Support inline replies

    Compare with previous version

  • robbie-demuth added 1 commit

    added 1 commit

    • 62376115 - Google Chat: Support inline replies

    Compare with previous version

  • 🤖 GitLab Bot 🤖 requested review from @.luke

    requested review from @.luke

  • @pedropombeiro @.luke @justin_ho, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
    • If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

    This message was generated automatically. You're welcome to improve it.

  • requested review from @ashrafkhamis

  • added UI text label

  • Ashraf Khamis approved this merge request

    approved this merge request

  • removed review request for @pedropombeiro and @ashrafkhamis

  • Luke Duncalfe approved this merge request

    approved this merge request

  • Luke Duncalfe requested review from @bmarjanovic and removed review request for @.luke

    requested review from @bmarjanovic and removed review request for @.luke

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Category Reviewer Maintainer
    backend @jnutt profile link current availability (UTC+0) @grzesiek profile link current availability (UTC+1)
    groupimport and integrate (backend) @rodrigo.tomonari profile link current availability (UTC-3) Maintainer review is optional for groupimport and integrate (backend)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 1ae2e612

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 21     | 0      | 5       | 0     | 26    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 1ae2e612

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 153    | 0      | 34      | 0     | 187   | ✅     |
    | Manage      | 39     | 0      | 11      | 2     | 50    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 218    | 0      | 47      | 2     | 265   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • requested review from @justin_ho

  • @justin_ho @bmarjanovic, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
    • If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

    This message was generated automatically. You're welcome to improve it.

  • added 1 commit

    • 1ae2e612 - Google Chat: Support inline replies

    Compare with previous version

  • robbie-demuth reset approvals from @.luke and @justin_ho by pushing to the branch

    reset approvals from @.luke and @justin_ho by pushing to the branch

  • Bojan Marjanovic
  • Bojan Marjanovic approved this merge request

    approved this merge request

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • Bojan Marjanovic enabled an automatic merge when all merge checks for 1ae2e612 pass

    enabled an automatic merge when all merge checks for 1ae2e612 pass

  • @robbie-demuth, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • @robbie-demuth, congratulations for getting your first MR merged :tada:

    If this is your first MR against a GitLab project, we'd like to invite and encourage you to self-nominate yourself for First MR Merged swag prize here.

    Thank you again for contributing, what's your next contribution going to be? :thinking:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 350c6d20

  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading