Use the AvatarCache for commits/events
What does this MR do and why?
Expands usage of the AvatarCache to cover a helper method used when rendering avatars in Git blame pages. This will improve performance by a reasonable margin on multiple endpoints that render large lists of authors in some capacity.
Changelog: performance
Related #220950
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.10
assigned to @robotmay_gitlab
- A deleted user
added backend bugperformance typebug labels
Reviewer roulette
Category Reviewer Maintainer backend @dfrazao-gitlab
(UTC+1, 1 hour ahead of author)
@mattkasa
(UTC-7, 7 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2a51bd3aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 66 | 0 | 9 | 0 | 75 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 79 | 0 | 10 | 0 | 89 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2a51bd3aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 568 | 0 | 62 | 0 | 630 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 594 | 0 | 64 | 0 | 658 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6173469758 spec/features/commit_spec.rb#L68
Commit behaves like single commit view pagination shows paginated content and controls to navigate 63.08 s < 50.13 s - A deleted user
added rspec:slow test detected label
added groupsource code label
added Category:Source Code Management devopscreate sectiondev labels
- Resolved by Joe Woodward
- Resolved by Joe Woodward
Passing to @imand3r for initial review
requested review from @imand3r
- A deleted user
added feature flag label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c7ddf30d
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d3c78def
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@a2fde2fa
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6ade3584
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5cc3627b
- Resolved by Joe Woodward
Reassigning to @mkhalifa3 as it's a public holiday in the US today
requested review from @mkhalifa3 and removed review request for @imand3r
- Resolved by Joe Woodward
- Resolved by Robert May
- Resolved by Joe Woodward
- Resolved by Robert May
- Resolved by Robert May
removed review request for @mkhalifa3
requested review from @jwoodwardgl
LGTM @robotmay_gitlab.
added pipeline:mr-approved label
- Resolved by Joe Woodward
@jwoodwardgl
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
enabled an automatic merge when the pipeline for a8d52ce5 succeeds
mentioned in commit 827943f8
mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1383 (closed)
added workflowpost-deploy-db-staging label
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label
mentioned in issue gitlab-org/quality/triage-reports#20597 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20960 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21530 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22034