Skip to content

Remove broken SCSS rule

Lukas Eipert requested to merge remove-broken-css into master

What does this MR do and why?

Remove broken SCSS rule

When working on the new CSS compiler, we found this broken SCSS rule, which simplified looks like this:

.class::before {
  &.other-class {
    top: 30px;
  }
}

It currently compiles to .class.other-class::before. In the new SASS compiler, it compiles to .class::before.other-class which is invalid. It's really confusing why this works currently, and it's the only of this in our code base.

Luckily for us, the rule seems obsolete (I suspect that something in !135038 (merged) might have fixed it).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

video3184414755

How to set up and validate locally

N/A

Edited by Lukas Eipert

Merge request reports