Update redis-client to v0.20.0
What does this MR do and why?
This fixes a few bugs in the hiredis-client, which we don't use, and freezes the command prelude (https://github.com/redis-rb/redis-client/pull/173). The latter prevents an issue we found with the Peek adapter mutating the AUTH password (gitlab-com/gl-infra/scalability#2826) after the upgrade to the redis v5 gem. That issue has since been fixed with !144388 (merged).
Merge request reports
Activity
assigned to @stanhu
- Resolved by Kevin Morrison
Dependency change review report
This automation is under testing, please leave your feedback in the issue.Modified Dependency: redis-client (0.20.0) Location:
Gemfile.lock
Version diffsChange in dependency identified, pinging @gitlab-com/gl-security/appsec for review. For review guidelines refer handbook page. Hi Appsec, please resolve this thread once review is completed.Checks passed: 6/6
-
️ Latest version: 0.20.0 released on: 2024-02-12. URL: https://rubygems.org/gems/redis-client -
Latest version is in use. -
Total downloads: 21204853 -
Reverse dependencies: 18 -
Total number of releases: 36 -
Latest version age (months): 0 -
Source project in Github not archived. -
️ Maintainer emails are private. Email domain check skipped.
-
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @serenafang
(UTC-6, 2 hours ahead of author)
@tachyons-gitlab
(UTC+5.5, 13.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@stanhu - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by 🤖 DepSASTer Bot by GitLab AppSec 🤖
NON-BLOCKING: This MR has changed Gemfile.checksum. GitLab team members should review the following dependency SAST scans when they finish:If there appear to be any true-positive vulnerabilities identified with CRITICAL or HIGH severity, if the report is misconfigured, or if you have questions, reply to this thread and mention
@gitlab-com/gl-security/appsec
.Otherwise, this does not require an AppSec review.
Please also review the Gemfile development AppSec guidelines. Thank you for keeping GitLab secure!
Generated by depSASTer. Open an issue to provide feedback.
changed milestone to %16.10
added maintenancedependency typemaintenance labels
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 099eb093expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Create | 53 | 0 | 12 | 0 | 65 | ✅ | | Package | 24 | 0 | 2 | 0 | 26 | ✅ | | Govern | 65 | 0 | 1 | 0 | 66 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Data Stores | 29 | 0 | 3 | 0 | 32 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 269 | 0 | 19 | 0 | 288 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 099eb093expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | Create | 548 | 0 | 93 | 18 | 641 | ✅ | | Plan | 246 | 0 | 13 | 0 | 259 | ✅ | | Data Stores | 106 | 0 | 41 | 1 | 147 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Manage | 39 | 0 | 11 | 3 | 50 | ✅ | | Govern | 271 | 0 | 22 | 1 | 293 | ✅ | | Package | 226 | 0 | 17 | 18 | 243 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 5 | 3 | 75 | 1 | 83 | ❌ | | Verify | 138 | 0 | 27 | 3 | 165 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1654 | 3 | 337 | 45 | 1994 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userrequested review from @serenafang
mentioned in merge request !144300 (merged)
- Resolved by Stan Hu
@serenafang
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
LGTM @stanhu, thanks!
requested review from @tachyons-gitlab and removed review request for @serenafang