Remove unreachable onboarding view code

What does this MR do and why?

Remove unreachable onboarding view code

• welcome page is only reachable via Gitlab.com, see https://gitlab.com/gitlab-org/gitlab/-/blob/53caa2cb049824e38a27c8e93280ace5bba849f8/ee/app/controllers/registrations/welcome_controller.rb#L15, so we can remove the Gitlab.com? conditional and branching for self-managed.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

changed milestone to %16.10

added groupacquisition maintenanceremoval typemaintenance workflowin dev labels

assigned to @dstull

added devopsgrowth sectiongrowth labels

added backend frontend labels

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@mkhalifa3 (UTC+1, 6 hours ahead of author)	@proglottis (UTC+13, 18 hours ahead of author)
frontend	@sheldonled (UTC+0, 5 hours ahead of author)	@fguibert (UTC+10, 15 hours ahead of author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for c6e3e773

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Data Stores | 0      | 0      | 2       | 0     | 2     | ➖     |
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 19     | 0      | 6       | 0     | 25    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

changed the description

@rliu-gl can you please review backend? I don't think we need a frontend review here.

added workflowin review label and removed workflowin dev label

requested review from @rliu-gl

approved this merge request

requested review from @proglottis and removed review request for @rliu-gl

@rliu-gl, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

@dstull Some end-to-end (E2E) tests should run based on the stage label.

Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and wait for the tests in the follow-up-e2e:package-and-test-ee pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

Once done, apply the emoji on this comment.

Team members only: for any questions or help, reach out on the internal #test-platform Slack channel.

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 461d5470 succeeds

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#6167320950	spec/features/groups/show_spec.rb#L36	Group show page when signed in when user is an owner shows the invite banner and persists dismissal	63.02 s	< 50.13 s