Skip to content

Revert "Merge branch 'test-resource-logging-fix' into 'master'"

John McDonnell requested to merge revert-832f0cee into master

What does this MR do and why?

Revert "Merge branch 'test-resource-logging-fix' into 'master'"

This reverts merge request !143852 (merged)

There's been an uptick in failures in Verify Project artifacts when user tries bulk deletion successfully delete them since this MR was merged.

I noted that this test specifically uses some Parallel threads to start runners and I suspect that something in the MR doesn't account for that.

https://gitlab.com/gitlab-org/gitlab/-/blob/b670678239375f3223b4550e208a844e9798ec98/qa/qa/specs/features/browser_ui/4_verify/ci_project_artifacts/user_can_bulk_delete_artifacts_spec.rb#L48

NB - I also note that the failures mentioned here were observed in the original MR, but given that there was a single failure at that time, but it's clear that this is happening regularly since this was merged which is why I suspect this MR may need to be revisited.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • $ bundle exec rspec qa/specs/features/browser_ui/4_verify/ci_project_artifacts/user_can_bulk_delete_artifacts_spec.rb:30

Merge request reports