Skip to content

Test resource logging factory bot fix

Désirée Chevalier requested to merge test-resource-logging-fix into master

What does this MR do and why?

Fixes gitlab-org/quality/quality-engineering/team-tasks#2407 (comment 1756559299)

FactoryBot was going directly to the instance method fabricate_via_api! e.g. Resource#fabricate_via_api! instead of the class method Resource.fabricate_via_api! (which later calls the former), therefore it was not recording the resource for the test clean up scripts in log_and_record_fabrication.

We now call the class method and pass the resource instance.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Désirée Chevalier

Merge request reports