Fix Read more shadow in darkmode
What does this MR do and why?
Readmore shadow: Fix darkmode
Reported via @dnsmichi in #431615 (comment 1769735818)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to a profile page with a readme (e.g. http://gdk.test:3000/root)
- If no readme is setup, follow the instructions here: https://docs.gitlab.com/ee/user/profile/#add-details-to-your-profile-with-a-readme
Related to #431615 (closed), #424397 (closed)
Merge request reports
Activity
assigned to @seggenberger
changed milestone to %16.10
mentioned in issue #431615 (closed)
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @rhardarson
(UTC+1, same timezone as author)
@shampton
(UTC-7, 8 hours behind author)
UX @nickbrandt
(UTC-7, 8 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ae77671e and 329bcd94
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 3.13 MB 3.13 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.pipelines.new 264.06 KB 291.58 KB +27.52 KB 10.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for ae77671e. So we have used data from: 709a86f5.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Scott Hampton
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 329bcd94expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Package | 24 | 0 | 2 | 0 | 26 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 65 | 0 | 1 | 0 | 66 | ✅ | | Create | 53 | 0 | 12 | 0 | 65 | ✅ | | Data Stores | 29 | 0 | 3 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 269 | 0 | 19 | 0 | 288 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed review request for @jmiocene
- Resolved by Scott Hampton
@jmiocene
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
- Resolved by Scott Hampton
@shampton, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 07fec701