Skip to content

Use user locale to display delimiters and separators

What does this MR do and why?

This MR modifies numberToHumanSizeSplit to accept a local argument, in order to be used in the NumberToHumanSize so that it can reliably display delimiters and separators based on the user set locale.

The MR adopts the following strategy: it keeps numberToHumanSizeSplit new argument set to GITLAB_FALLBACK_LANGUAGE, and tries to scope down the visual impact that would result from this change. (I'm relying on tests and specs for areas where this might have an impact).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-02-26_at_16.23.30 Screenshot_2024-02-26_at_16.20.56

How to set up and validate locally

  1. Set a locale under -/profile/preferences
  2. Visit groups/<your-group>/-/usage_quotas#storage-quota-tab

Related to #439467 (closed)

Edited by Angelo Gulina

Merge request reports