Enable new CSS compiler by default
What does this MR do and why?
After analyzing the CSS diff between the new and old compiler, the diff doesn't have us concerned too much. We therefore want to enable the new SASS compiler in CI/CD to see if there are any failures.
Furthermore we turn it on in development by default as well
- See also: #438278 (closed)
- Link to the Diff: gitlab-org/frontend/playground/sass-compiler-diff!1 (comment 1758213709)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
- Restart
gdk restart rails-web vite
orgdk restart rails-web webpack
- You should see CSS files compiled in
app/assets/builds
- If you add
body{color: red !important}
toapp/assets/builds/application.css
and reload the page, then a few text bits should become red. This "proves" that the new gemcssbundling
is used. - If you now add
body{color: blue !important}
toapp/assets/stylesheets/application.scss
and reload the page, then a few text bits should become blue. This "proves" that vite/webpack started the new CSS compiler.
Merge request reports
Activity
assigned to @leipert
added frontend maintenancepipelines labels
added typemaintenance label
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Category Reviewer Maintainer backend @alexbuijs
(UTC+1, same timezone as author)
@mbobin
(UTC+2, 1 hour ahead of author)
frontend @elwyn-gitlab
(UTC+13, 12 hours ahead of author)
@mlunoe
(UTC+1, same timezone as author)
~"Tooling" Reviewer review is optional for ~"Tooling" @kushalpandya
(UTC+5.5, 4.5 hours ahead of author)
~"Tooling" Reviewer review is optional for ~"Tooling" @splattael
(UTC+1, same timezone as author)
~"Pipeline configuration" Reviewer review is optional for ~"Pipeline configuration" @ddieulivol
(UTC+1, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- A deleted user
added backend label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cb6e4bb9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 5 | 0 | 26 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for cb6e4bb9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 39 | 0 | 11 | 2 | 50 | ✅ | | Create | 148 | 0 | 39 | 4 | 187 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 213 | 0 | 52 | 6 | 265 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 11 commits
-
cef14c3e...90b65a33 - 10 commits from branch
master
- a13038cd - CI: Enable new CSS compiler by default
-
cef14c3e...90b65a33 - 10 commits from branch
added groupfoundations label
added devopsmanage sectioncore platform labels
changed milestone to %16.10
- Resolved by Paul Gascou-Vaillancourt
@alexbuijs Could your review backend? Please go with
@splattael
as a maintainer.@pgascouvaillancourt Do you have time to review?
cc/ FYI: @peterhegman @svedova @jivanvl @markrian
requested review from @alexbuijs and @pgascouvaillancourt