Migrate deprecated bs-callout to alert component in pages
What does this MR do and why?
Migrate deprecated bs-callout
to Pajamas::AlertComponent
in app/views/projects/pages/*
It's a part of Pajamas adoption project
Changed according to migration guide available in next epic: &5213 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Enable
external_http
for gitlab pages inconfig/gitlab.yml
:
development:
pages:
enabled: true
access_control: false
host: 127.0.0.1.nip.io
port: 3010
https: false # Set to true if you serve the pages with HTTPS
external_http: ["1.1.1.1:80", "[2001::1]:80"] # If defined, enables custom domain support in GitLab Pages
- Open some project
- Goto
Deploy -> Pages
- Setup pages(if required).
- Add new domain.
- Verify warning messages. You can mock next methods to see warnings:
app/presenters/pages_domain_presenter.rb#L6
app/presenters/pages_domain_presenter.rb#L10
-
Modify account namespace name (to include dot
.
) to see theHTTPS with subdomains of subdomains
warning message. -
Disable pages for this project or mock it here app/models/project.rb#L2123 to see the
pages are disabled
warning message.
Related to #441112 (closed)
Merge request reports
Activity
assigned to @ttaday-ext
2 Warnings e95e072d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @thutterer
(UTC+1)
@pedropombeiro
(UTC+1)
frontend @thomasrandolph
(UTC-7)
@zcuddy
(UTC-6)
test for spec/features/*
@thutterer
(UTC+1)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded Community contribution label
added linked-issue label
- Resolved by Zack Cuddy
This has been identified as a contribution from a Temporary Service Provider to GitLab. It is encouraged to seek review from at least one domain expert during the review process.
added Contractor Contribution label
added 1 commit
- e95e072d - Migrate deprecated bs-callout to alert component for gitlab pages
- Resolved by Zack Cuddy
@thomasrandolph can you please review this MR? Thanks!
requested review from @thomasrandolph
requested review from @zcuddy and removed review request for @thomasrandolph
- Resolved by Zack Cuddy
@thomasrandolph
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label