Skip to content

Migrate deprecated bs-callout to alert component in pages

Taras Tadai requested to merge 441112-migrate-pages-bs-collout-to-alert into master

What does this MR do and why?

Migrate deprecated bs-callout to Pajamas::AlertComponent in app/views/projects/pages/*

It's a part of Pajamas adoption project

Changed according to migration guide available in next epic: &5213

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
pages_warnings_old pages_warnings_new
pages_old2 pages_new2

How to set up and validate locally

  1. Enable external_http for gitlab pages in config/gitlab.yml:
development:
  pages:
    enabled: true
    access_control: false
    host: 127.0.0.1.nip.io
    port: 3010
    https: false # Set to true if you serve the pages with HTTPS
    external_http: ["1.1.1.1:80", "[2001::1]:80"] # If defined, enables custom domain support in GitLab Pages
  1. Open some project
  2. Goto Deploy -> Pages
  3. Setup pages(if required).
  4. Add new domain.
  5. Verify warning messages. You can mock next methods to see warnings:

app/presenters/pages_domain_presenter.rb#L6

app/presenters/pages_domain_presenter.rb#L10

  1. Modify account namespace name (to include dot .) to see the HTTPS with subdomains of subdomains warning message.

  2. Disable pages for this project or mock it here app/models/project.rb#L2123 to see the pages are disabled warning message.

Related to #441112 (closed)

Edited by Taras Tadai

Merge request reports