Skip to content

Fix missing outbound_local_requests_allowlist parameter

Furkan Ayhan requested to merge fix-missing-outbound_local_requests_allowlist-for-urlblocker into master

What does this MR do and why?

When we migrated UrlBlocker to HTTP_V2::UrlBlocker, we missed passing the outbound_local_requests_allowlist parameter to the HTTP_V2::UrlBlocker class from AddressableUrlValidator.

This will break the Filtering outbound requests feature.

In this commit, we are passing the parameter as ApplicationSetting.current.outbound_local_requests_whitelist and write related tests to cover it.

Bug was introduced in !141349 (merged)

Also related to #430830.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Furkan Ayhan

Merge request reports