Clean up old Gitlab::HTTP related codes
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
After closing #415686 (closed) and #426549 (closed), we need to remove old Gitlab::HTTP related codes from the codebase.
- Check
Gitlab::HTTPConnectionAdapterand its usage places. - Check
Gitlab::NetHttpAdapterand its usage places. - Check
Gitlab::UrlBlockerand its usage places. - Check
Gitlab::UrlBlockers::UrlAllowlistand its usage places. - Check
Gitlab::UrlBlockers::DomainAllowlistEntryand its usage places. - Check
Gitlab::UrlBlockers::IpAllowlistEntryand its usage places. - Check
Gitlab::BufferedIoand its usage places. - Fix the usage of
deny_all_requests_except_allowedbecause it will never be a Proc. -
Gitlab::CurrentSettings.network_settings; !143050 (comment 1755064637) - Fix the comment in #440772
-
!148368 (comment 1843748064) "Maybe this could be extracted as a separate class to be reused in the other service? so that we clump together the options and logic so that they stay in sync."
Edited by 🤖 GitLab Bot 🤖