Skip to content

Remove old finding modal from mr widget security reports

Lorenz van Herwaarden requested to merge remove-old-finding-modal-from-mr-widget-security-reports into master

What does this MR do and why?

Related #426523 (closed)

We've enabled standalone_finding_modal_merge_request_widget by default in %16.9. The E2E specs related to this feature flag being disabled were removed in Remove old finding modal E2E specs (!144643 - merged).

This MR removes the use of the old finding modal in the MR Security widget. A lot of computed properties, reactive properties, methods, graphql queries and mutations, and imports can be removed because the new finding modal handles this internally and is way more "standalone". This MR also removes the tests specific for this old modal.

In a later iteration, the whole old finding modal can be removed: Remove old finding modal (#441279 - closed) • Lorenz van Herwaarden • 16.10

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Lorenz van Herwaarden

Merge request reports