[Feature flag] Cleanup standalone_finding_modal_merge_request_widget

Summary

This issue is to cleanup the standalone_finding_modal_merge_request_widget feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

1. Remove all properties, methods, imports, ... related to the old finding modal in ee/app/assets/javascripts/vue_merge_request_widget/extensions/security_reports/mr_widget_security_reports.vue
2. Remove E2E specs related to old finding modal on MR security widget

Owners

• Team: groupthreat insights Threat InsightsNavy
• Most appropriate slack channel to reach out to: #g_govern_threat_insights_navy
• Best individual to reach out to: @lorenzvanherwaarden
• PM: @abellucci

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

• Create a merge request to remove standalone_finding_modal_merge_request_widget feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
  • Remove following from ee/app/assets/javascripts/vue_merge_request_widget/extensions/security_reports/mr_widget_security_reports.vue
    • import of 'ee/vue_shared/security_reports/components/modal.vue'
    • all computed properties, state properties, methods that are related to the old finding modal
• Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
  • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
• Close the feature issue to indicate the feature will be released in the current milestone.
• If not already done, clean up the feature flag from all environments by running these chatops command in #production channel:
  • /chatops run feature delete standalone_finding_modal_merge_request_widget --dev
  • /chatops run feature delete standalone_finding_modal_merge_request_widget --staging
  • /chatops run feature delete standalone_finding_modal_merge_request_widget
• Close this rollout issue.