Remove ci_job_token_groups_allowlist feature flag
Rollout issue: #439611 (closed) Original issue: #435903 (closed) Original MR: !142441 (merged)
In the scope of the rollout issue Remove ci_job_token_groups_allowlist
feature flag of Backend: API allowing projects to add groups in their CI_JOB_TOKEN allowlist, following the global activation on production environments and testing, it is necessary to deactivate this feature flag.
Changelog: other
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @dbiryukov
- A deleted user
added backend label
2 Warnings There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Category Reviewer Maintainer backend @jmontal
(UTC-7, 8 hours behind author)
@tianwenchen
(UTC+11, 10 hours ahead of author)
~"Verify" Reviewer review is optional for ~"Verify" @lauraXD
(UTC+1, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@811d8634
added sectionci label and removed sectionops label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1e192a7dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 52 | 0 | 4 | 0 | 56 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1e192a7dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 153 | 0 | 19 | 0 | 172 | ✅ | | Verify | 200 | 0 | 36 | 0 | 236 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 57 | 0 | 436 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
@iamricecake Could you please take a backend review?
requested review from @iamricecake
mentioned in issue #435903 (closed)
- Resolved by Erick Bajao
@iamricecake
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 7f930111 succeeds
mentioned in commit b3184041
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
changed milestone to %16.10
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
mentioned in issue #414583 (closed)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label