Removes direct data manipulation from abuse_category_selector_spec
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR resolves #441145 (closed)
What was cleaned up from epic:
- Remove
direct data manipulation
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
- Run it also with
VUE_VERSION=3 yarn jest --watch
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.9
assigned to @arfedoro
1 Message 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @robyrne
(UTC+0, 1 hour behind author)
@svedova
(UTC+1, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4e802f7e and 0e194258
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 3.13 MB 3.13 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost UserE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 0e194258expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 65 | 0 | 1 | 0 | 66 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 81 | 0 | 7 | 0 | 88 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
✅ test report for 0e194258expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 271 | 0 | 22 | 1 | 293 | ✅ | | Create | 148 | 0 | 24 | 4 | 172 | ✅ | | Data Stores | 0 | 0 | 4 | 0 | 4 | ➖ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 52 | 5 | 487 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userrequested review from @robyrne
- Resolved by Savas Vedova
- Resolved by Savas Vedova
- Resolved by Savas Vedova
👋 @robyrne
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when all merge checks for be8a83b0 pass
added 191 commits
-
be8a83b0...6d774664 - 190 commits from branch
master
- 0e194258 - This MR removes direct data manipulation
-
be8a83b0...6d774664 - 190 commits from branch