Skip to content
Snippets Groups Projects

Removes direct data manipulation from abuse_category_selector_spec

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR resolves #441145 (closed)

What was cleaned up from epic:

  1. Remove direct data manipulation

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

NO VISUAL CHANGES

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Checkout branch
  2. Run test locally
  3. Or just check in pipeline
  4. Run it also with VUE_VERSION=3 yarn jest --watch 

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Merged results pipeline #1173063130 passed

Pipeline: Ruby 3.1 as-if-foss pipeline

#1173066549

    Pipeline: E2E GDK

    #1173070460

      Pipeline: GitLab

      #1173070577

        +2

        Merged results pipeline passed for 0bbe06f0

        Test coverage 81.50% from 2 jobs

        Merged by Savas VedovaSavas Vedova 1 year ago (Feb 12, 2024 10:28am UTC)

        Loading

        Pipeline #1173210867 passed

        Pipeline passed for cd616c9f on master

        Test coverage 64.79% from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • Ross Byrne approved this merge request

        approved this merge request

      • Ross Byrne requested review from @svedova and removed review request for @robyrne

        requested review from @svedova and removed review request for @robyrne

      • Savas Vedova approved this merge request

        approved this merge request

      • Savas Vedova resolved all threads

        resolved all threads

      • Savas Vedova enabled an automatic merge when all merge checks for be8a83b0 pass

        enabled an automatic merge when all merge checks for be8a83b0 pass

      • Artur Fedorov aborted the automatic merge because source branch was updated

        aborted the automatic merge because source branch was updated

      • Artur Fedorov added 191 commits

        added 191 commits

        Compare with previous version

      • Savas Vedova resolved all threads

        resolved all threads

      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Please register or sign in to reply
        Loading