Skip to content

Change route "/details" to "/failures" (with id)

Justin Ho Tuan Duong requested to merge 433212-review-bulk_import-history-failures-page-routes into master

What does this MR do and why?

Previous MR !143322 (merged) updated the URL for the history page. This second MR updates the failures page which is under the history page.

  • Rename "details" to "failures" in URL to match frontend copy and avoid confusion.
  • Change URL from /import/bulk_imports/details?id=147&entity_id=73 (using URL params) to /import/bulk_imports/147/history/73/failures (have id and entity_id inside the URL).
  • Update frontend links and backend controllers.

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No changes to UI, only change in links. Bulk_import_failures

How to set up and validate locally

Import groups by direct transfer

  1. On the left sidebar, at the top, select Create new... (+) and New group. Then select Import group.
  2. In GitLab source instance base URL, enter your GDK URL. For example, http://127.0.0.1:3000.
  3. In Personal access token, enter a token from your GDK.
  4. Select Connect instance.
  5. Apply the following diff to make some import items fail intentionally:
diff --git a/lib/bulk_imports/ndjson_pipeline.rb b/lib/bulk_imports/ndjson_pipeline.rb
index 07118c3b55c0..5988e998afd2 100644
--- a/lib/bulk_imports/ndjson_pipeline.rb
+++ b/lib/bulk_imports/ndjson_pipeline.rb
@@ -35,6 +35,8 @@ def transform(context, data)
       end
 
       def load(_context, object)
+        raise StandardError.new('Error!')
+
         return unless object
 
         if object.new_record?
  1. Start a few imports with any group and let them run.
  2. Click on the History link on the upper right corner to view the history page. For example, http://127.0.0.1:3000/import/bulk_imports/history.
  3. Find an import item with failures and click the See failures link in the status column.
  4. You should be on the Failures page. For example, http://127.0.0.1:3000/import/bulk_imports/121/history/63/failures.

Related to #433212 (closed)

Merge request reports