Skip to content

Replace URL param with proper route for bulk_import history items

Justin Ho Tuan Duong requested to merge 433212-review-bulk_import-history-page-routes into master

What does this MR do and why?

  • Replaces the URL that looks like /import/bulk_imports/history?bulk_import_id=147 with /import/bulk_imports/147/history where 147 is the id of the bulk_import. This is closer to standard Rails routes.
  • Add backend logic to render a 404 page when id is passed but bulk_import does not exist.

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No changes to UI. Only changes to links in the URL / breadcrumbs / UI.

Before After
/import/bulk_imports/history?bulk_import_id=147 /import/bulk_imports/147/history

How to set up and validate locally

Import groups by direct transfer

  1. On the left sidebar, at the top, select Create new... (+) and New group. Then select Import group.
  2. In GitLab source instance base URL, enter your GDK URL. For example, http://127.0.0.1:3000.
  3. In Personal access token, enter a token from your GDK.
  4. Select Connect instance.
  5. Start any import, then click on the History link on the upper right corner.

Related to #433212 (closed)

Merge request reports