Mark issuable-resource-links as unique on create
What does this MR do and why?
Mark issuable-resource-links as unique on create
Context: #437902
Depends on: !141549 (merged) in release 16.9
We mark every newly created issuable-resource-link as is_unique=true. There is a partial unique index on the database table that will ensure that going forward no two records are duplicates.
As this work needs to be in a subsequent release from the dependency, we aim to release this in no sooner than release 16.10.
EE: true
Changelog: fixed
Merge request reports
Activity
Hey @tomasz.skorupa!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @tomasz.skorupa
added linked-issue label
2 Warnings 3cd34d69: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @radbatnag
(UTC+8)
@bmarjanovic
(UTC+1)
database @johnmason
(UTC-5)
@mbobin
(UTC+2)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 422 commits
-
9fa669f8...0e7931c6 - 422 commits from branch
gitlab-org:master
-
9fa669f8...0e7931c6 - 422 commits from branch
added 1 commit
- cc2cec81 - Mark issuable-resource-links as unique on create
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi Coach
@terrichu
, this Community contribution is ready for review or needs your coaching.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
requested review from @terrichu
- Resolved by Tomasz Skorupa
added database databasereview pending labels
changed milestone to %16.9
added grouprespond label
added devopsservice management sectionseg labels
@carlad-gl would you mind taking the initial backend review?
requested review from @carlad-gl
requested review from @jdrpereira and removed review request for @terrichu