Skip to content

Remove Defunct Code in SetUserStatusBasedOnUserCapSettingWorker

Jason Goodman requested to merge remove-defunct-set-user-status-worker-code into master

What does this MR do and why?

Remove defunct code in SetUserStatusBasedOnUserCapSettingWorker.

This code is no longer executed except in an edge case. In the edge case that it still runs, it doesn't need to; it would be fine to leave the user in the blocked pending approval state.

See the issue for more details: #439642 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Set an instance wide user cap.
  2. Use some puts debugging statements (or however else you prefer to debug) to validate the following:
    • If the user cap is exceeded, and a new user signs up, this worker is executed, but the code past the user cap check is not executed.
    • If the user cap is not exceeded, and a new user signs up, then this worker is not executed.

In either scenario, the code deleted in this MR does not run.

Merge request reports